[PATCH] avoid set-but-not-used warning

[PATCH] avoid set-but-not-used warning

[Jim Meyering]

I noticed this on master (also applies to next), compiling with gcc-4.6:

    diffcore-rename.c: In function 'diffcore_rename':
    diffcore-rename.c:501:18: warning: variable 'num_src' set but not used \
      [-Wunused-but-set-variable]

Here's the fix:

-- >8 --
Subject: [PATCH] avoid set-but-not-used warning

* diffcore-rename.c (diffcore_rename): Remove declaration and set.

Signed-off-by: Jim Meyering <meyering@redhat.com>
---
 diffcore-rename.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/diffcore-rename.c b/diffcore-rename.c
index f62587e..3d65bb3 100644
--- a/diffcore-rename.c
+++ b/diffcore-rename.c
@@ -498,7 +498,7 @@ void diffcore_rename(struct diff_options *options)
 	struct diff_queue_struct outq;
 	struct diff_score *mx;
 	int i, j, rename_count, skip_unmodified = 0;
-	int num_create, num_src, dst_cnt;
+	int num_create, dst_cnt;
 	struct progress *progress = NULL;

 	if (!minimum_score)
@@ -554,7 +554,6 @@ void diffcore_rename(struct diff_options *options)
 	 * files still remain as options for rename/copies!)
 	 */
 	num_create = (rename_dst_nr - rename_count);
-	num_src = rename_src_nr;

 	/* All done? */
 	if (!num_create)
--
1.7.5.452.gcf2d0

Re: [PATCH] avoid set-but-not-used warning

[Junio C Hamano]

Thanks.

Re: [PATCH] avoid set-but-not-used warning

[Thiago Farina]

On Fri, Apr 29, 2011 at 1:28 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Thanks.

Ingo Molnar has posted the same fix in "diffcore-rename: Remove unused
variable 'num_src'".

> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Re: [PATCH] avoid set-but-not-used warning

[Junio C Hamano]

Thiago Farina <tfransosi@gmail.com> writes:

> On Fri, Apr 29, 2011 at 1:28 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> Thanks.
>
> Ingo Molnar has posted the same fix in "diffcore-rename: Remove unused
> variable 'num_src'".

What do you want _me_ to do about that?

If this were addressed to Jim I may kind-of understand what you were
trying to say, but you addressed me, and I am puzzled.