From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nguyen Thai Ngoc Duy Subject: Re: [PATCH 1/3] t3700: note a .gitignore matching fault Date: Wed, 4 May 2011 08:05:08 +0700 Message-ID: References: <1304340464-14829-1-git-send-email-pclouds@gmail.com> <1304340923-15927-1-git-send-email-pclouds@gmail.com> <4DBEC766.8020008@viscovery.net> <7voc3jis61.fsf@alter.siamese.dyndns.org> <7vd3jzgww8.fsf@alter.siamese.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Johannes Sixt , git@vger.kernel.org To: Junio C Hamano X-From: git-owner@vger.kernel.org Wed May 04 03:05:48 2011 Return-path: Envelope-to: gcvg-git-2@lo.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QHQXB-00017r-MZ for gcvg-git-2@lo.gmane.org; Wed, 04 May 2011 03:05:46 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754802Ab1EDBFk convert rfc822-to-quoted-printable (ORCPT ); Tue, 3 May 2011 21:05:40 -0400 Received: from mail-bw0-f46.google.com ([209.85.214.46]:49436 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753554Ab1EDBFk convert rfc822-to-8bit (ORCPT ); Tue, 3 May 2011 21:05:40 -0400 Received: by bwz15 with SMTP id 15so579824bwz.19 for ; Tue, 03 May 2011 18:05:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type:content-transfer-encoding; bh=+7zwYxSo6TBFl5pYbQnVhc9NAbXIPSHYsw4hXAEasPw=; b=CHib2oYsKmwBzV2ysq835aNEpLQXLgmP2ZUMEr+kZ4oEH/v7VtIx/iV5SiCCCr1tVm wvz/dNdWNFuuRe4CIaLL86VTISw9jbyi/Lnj09tI1Lcz+xykVHnLwQ232NCj5RZUdjjg MUGk6B+Ddask8K27cValbRp+mnES1mQs/JZe0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=VYRknXO2Y+n6SlkvlfwLtJ3aLAqdhfm76jn2adPLlC8nEy5cLfJN+Bb+m6HY1ghgPg +ialEvOdzWtnmGwjE4oRwfVqaIOzzai5bBZEkumu9qdnaCE1xVeSLEMcsQLEDGdvIncG VPwkaZ2Uk4ekfejakFCju/H7dGNCuiyN1r/cM= Received: by 10.204.45.152 with SMTP id e24mr465823bkf.47.1304471138158; Tue, 03 May 2011 18:05:38 -0700 (PDT) Received: by 10.204.53.13 with HTTP; Tue, 3 May 2011 18:05:08 -0700 (PDT) In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Wed, May 4, 2011 at 7:41 AM, Nguyen Thai Ngoc Duy wrote: > On Wed, May 4, 2011 at 6:57 AM, Junio C Hamano wr= ote: >> Nguyen Thai Ngoc Duy writes: >> >>> Yes. But git still silently ignores some rules in the .gitignore. >> >> Do you want git to report each and every entry in .gitignore saying = "this >> rule does not apply"? =C2=A0That sounds like madness to me. > > This rule should apply, but not because of "efficiency reasons". Not > just about any rule. Maybe something like this instead of a implemantation fix? diff --git a/Documentation/gitignore.txt b/Documentation/gitignore.txt index 8416f34..81e9d43 100644 --- a/Documentation/gitignore.txt +++ b/Documentation/gitignore.txt @@ -71,6 +71,8 @@ PATTERN FORMAT matching file excluded by a previous pattern will become included again. If a negated pattern matches, this will override lower precedence patterns sources. + If a directory is excluded by earlier patterns, negated + patterns that touch files inside the directory will be ignored. - If the pattern ends with a slash, it is removed for the purpose of the following description, but it would only find --=20 Duy