From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/4] convert.c clean-up
Date: Tue, 10 May 2011 19:59:29 +0700 [thread overview]
Message-ID: <BANLkTi=fjLkqWB2MTGtKE93qSjXU76cpvA@mail.gmail.com> (raw)
In-Reply-To: <1304978701-19310-1-git-send-email-gitster@pobox.com>
On Tue, May 10, 2011 at 5:04 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Yeah, I think that would probably make more sense. If a file is small
> enough, it is more sensible to send it to a loose object just like any
> other files. We do not want to invite users to make a mistake of marking
> it as bigdata and send it straight to a packfile. Having one less knob to
> tweak is always a good thing to do.
>
> However, while reviewing your patch, I noticed that convert.c was littered
> with misnamed types, variables and functions to the point to make it
> almost unreadble as the result of its evolution. I originally wrote this
> series so that I can add "bigdata" sensibly, and it turns out that there
> is no benefit to do so for now, but the clean-up by itself would be worth
> it.
I still don't like "bigdata" attribute. It sounds overlapping with
bigFileThreshold we already have. Maybe "inPack", "packed" or
"noLoose" a better name? It makes it quite clear that this attribute
sends objects to a pack. If they want to process tiny files this way
by setting inPack/noLoose, I don't care. But files larger than
core.bigFileThreshold should be automatically marked "inPack/noLoose".
> So there...
Yeah, I wish you did this before I touched convert.c. Anyway it looks
better from now on.
--
Duy
next prev parent reply other threads:[~2011-05-10 13:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-08 8:47 [PATCH v0 0/3] git add a-Big-file Junio C Hamano
2011-05-08 8:47 ` [PATCH v0 1/3] index_fd(): turn write_object and format_check arguments into one flag Junio C Hamano
2011-05-08 8:47 ` [PATCH v0 2/3] index_fd(): split into two helper functions Junio C Hamano
2011-05-08 8:47 ` [PATCH v0 3/3] Bigfile: teach "git add" to send a large file straight to a pack Junio C Hamano
2011-05-08 10:19 ` Nguyen Thai Ngoc Duy
2011-05-08 17:37 ` Junio C Hamano
2011-05-09 22:04 ` [PATCH 0/4] convert.c clean-up Junio C Hamano
2011-05-09 22:04 ` [PATCH 1/4] convert: rename the "eol" global variable to "core_eol" Junio C Hamano
2011-05-09 22:04 ` [PATCH 2/4] convert: give saner names to crlf/eol variables, types and functions Junio C Hamano
2011-05-09 22:05 ` [PATCH 3/4] convert: make it safer to add conversion attributes Junio C Hamano
2011-05-09 22:05 ` [PATCH 4/4] convert: make it harder to screw up adding a conversion attribute Junio C Hamano
2011-05-10 12:59 ` Nguyen Thai Ngoc Duy [this message]
2011-05-10 14:09 ` [PATCH 0/4] convert.c clean-up Junio C Hamano
2011-05-09 14:05 ` [PATCH v0 3/3] Bigfile: teach "git add" to send a large file straight to a pack Shawn Pearce
2011-05-09 15:58 ` Junio C Hamano
2011-05-09 16:14 ` Junio C Hamano
2011-05-29 18:20 ` Ævar Arnfjörð Bjarmason
2011-05-29 20:29 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=fjLkqWB2MTGtKE93qSjXU76cpvA@mail.gmail.com' \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).