From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jakob Pfender <jpfender@elegosoft.com>,
git@vger.kernel.org, torvalds@osdl.org, spearce@spearce.org,
johannes.schindelin@gmx.de, peff@peff.net, nico@fluxnic.net,
barkalow@iabervon.org, chriscool@tuxfamily.org,
jrnieder@gmail.com, raa.lkml@gmail.com,
Matthieu.Moy@grenoble-inp.fr,
Johannes Sixt <j.sixt@viscovery.net>
Subject: Re: [PATCH] Documentation/git-update-index.txt: Remove obsolete note
Date: Sat, 2 Apr 2011 15:52:07 +0700 [thread overview]
Message-ID: <BANLkTi=gadRz0XXp2Jd1Jnv7hH4fbnE45Q@mail.gmail.com> (raw)
In-Reply-To: <7v7hbfj7d6.fsf@alter.siamese.dyndns.org>
On Fri, Apr 1, 2011 at 4:41 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Nguyen Thai Ngoc Duy <pclouds@gmail.com> writes:
>
>> On Wed, Mar 30, 2011 at 8:01 PM, Jakob Pfender <jpfender@elegosoft.com> wrote:
>>> 8dcf39 (Prevent bogus paths from being added to the index) introduced a
>>> check for files beginning with '.', preventing path names such as
>>> `./file`, `dir/./file` or `dir/../file` from being added. This was
>>> reflected in the man page.
>>>
>>> d089eba (setup: sanitize absolute and funny paths in get_pathspec())
>>> removed this check without reflecting the change in the man page.
>>
>> Sounds good.
>
> When I first read it, however, I thought that the "removal" meant that the
> rewrite made the code riskier by accepting nonsense, which turns out not
> to be what the author meant. It was more like "instead of rejecting,
> accept these paths after normalizing", no?
>
Yes it's more like that.
--
Duy
prev parent reply other threads:[~2011-04-02 8:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-30 13:01 [PATCH] Documentation/git-update-index.txt: Remove obsolete note Jakob Pfender
2011-03-31 12:15 ` Nguyen Thai Ngoc Duy
2011-03-31 15:18 ` Jakob Pfender
2011-03-31 21:41 ` Junio C Hamano
2011-04-02 8:52 ` Nguyen Thai Ngoc Duy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=gadRz0XXp2Jd1Jnv7hH4fbnE45Q@mail.gmail.com' \
--to=pclouds@gmail.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=barkalow@iabervon.org \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
--cc=johannes.schindelin@gmx.de \
--cc=jpfender@elegosoft.com \
--cc=jrnieder@gmail.com \
--cc=nico@fluxnic.net \
--cc=peff@peff.net \
--cc=raa.lkml@gmail.com \
--cc=spearce@spearce.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).