From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
To: Michael J Gruber <git@drmicha.warpmail.net>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Matej Batic <matej.batic@ge.infn.it>
Subject: Re: [PATCH 2/2] handle_alias: provide GIT_PREFIX to !alias
Date: Wed, 27 Apr 2011 16:06:09 +0700 [thread overview]
Message-ID: <BANLkTi=gjuOqLEArk_0Nj1faEu62dzjbZA@mail.gmail.com> (raw)
In-Reply-To: <5058a9853a75bff71187f553e67632997761de44.1303893279.git.git@drmicha.warpmail.net>
2011/4/27 Michael J Gruber <git@drmicha.warpmail.net>:
> @@ -589,6 +589,8 @@ it will be treated as a shell command. For example, defining
> "gitk --all --not ORIG_HEAD". Note that shell commands will be
> executed from the top-level directory of a repository, which may
> not necessarily be the current directory.
> +'GIT_PREFIX' is set as returned by running 'git rev-parse --show-prefix'
> +from the original current directory. See linkgit:git-rev-parse[1].
It made me wonder "but then why should not we just do GIT_PREFIX=`git
rev-parse --show-prefix` in the alias?" then realized by the time we
do that, it's already too late. Maybe
> +'GIT_PREFIX' is set as returned by running 'git rev-parse --show-prefix'
> +before current directory is changed to top-level directory. See linkgit:git-rev-parse[1].
?
--
Duy
next prev parent reply other threads:[~2011-04-27 9:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4DA59B27.50506@ge.infn.it>
2011-04-13 13:05 ` [RFC/PATCH] handle_alias: provide GIT_CWD to !alias Michael J Gruber
2011-04-13 13:12 ` Nguyen Thai Ngoc Duy
2011-04-13 13:16 ` Michael J Gruber
2011-04-13 13:24 ` Nguyen Thai Ngoc Duy
2011-04-26 22:22 ` Junio C Hamano
2011-04-27 6:47 ` Michael J Gruber
2011-04-27 7:40 ` Nguyen Thai Ngoc Duy
2011-04-27 8:10 ` Michael J Gruber
2011-04-27 8:36 ` [PATCH 1/2] t1020: test !alias in subdirectory Michael J Gruber
2011-04-27 8:36 ` [PATCH 2/2] handle_alias: provide GIT_PREFIX to !alias Michael J Gruber
2011-04-27 9:06 ` Nguyen Thai Ngoc Duy [this message]
2011-04-27 9:36 ` Michael J Gruber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=gjuOqLEArk_0Nj1faEu62dzjbZA@mail.gmail.com' \
--to=pclouds@gmail.com \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=matej.batic@ge.infn.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).