From: Felipe Contreras <felipe.contreras@gmail.com>
To: Marius Storm-Olsen <marius@storm-olsen.com>
Cc: "Shawn O. Pearce" <spearce@spearce.org>,
Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Marius Storm-Olsen <mstormo@gmail.com>
Subject: Re: [PATCH] Automatically autoload bashcompinit for ZSH, when needed
Date: Wed, 27 Apr 2011 04:22:21 +0300 [thread overview]
Message-ID: <BANLkTi=qzBGmp80088hVrc+yicH2ofDGEg@mail.gmail.com> (raw)
In-Reply-To: <BANLkTindtTVcLetYs1wJ0K9BcQO7YNYpvw@mail.gmail.com>
On Wed, Apr 27, 2011 at 4:11 AM, Felipe Contreras
<felipe.contreras@gmail.com> wrote:
> On Tue, Apr 26, 2011 at 11:28 PM, Marius Storm-Olsen
> <marius@storm-olsen.com> wrote:
>> If bashcompinit has not already been autoloaded, do so
>> automatically, as it is required to properly parse the
>> git-completion file with ZSH.
>>
>> Signed-off-by: Marius Storm-Olsen <mstormo@gmail.com>
>> ---
>
>> +if [[ -n ${ZSH_VERSION-} ]]; then
>> + if ! bashcompinit >/dev/null 2>&1; then
>> + autoload -U bashcompinit
>> + bashcompinit
>> + fi
>
> How about this instead?
> autoload -UX bashcompinit && bashcompinit
Er, autoload -U +X.
--
Felipe Contreras
next prev parent reply other threads:[~2011-04-27 1:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-26 13:24 [PATCH] Refactor git-completion to allow ZSH usage of PS1 functions Marius Storm-Olsen
2011-04-26 17:21 ` Junio C Hamano
2011-04-26 17:37 ` Marius Storm-Olsen
2011-04-26 19:15 ` Junio C Hamano
2011-04-26 20:28 ` [PATCH] Automatically autoload bashcompinit for ZSH, when needed Marius Storm-Olsen
2011-04-26 20:47 ` Matthieu Moy
2011-04-26 20:52 ` Marius Storm-Olsen
2011-04-26 21:55 ` Junio C Hamano
2011-04-27 1:11 ` Felipe Contreras
2011-04-27 1:22 ` Felipe Contreras [this message]
2011-04-27 3:23 ` [PATCH v2] " Marius Storm-Olsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=qzBGmp80088hVrc+yicH2ofDGEg@mail.gmail.com' \
--to=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=marius@storm-olsen.com \
--cc=mstormo@gmail.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).