From: Avery Pennarun <apenwarr@gmail.com>
To: Sverre Rabbelier <srabbelier@gmail.com>
Cc: "Jeff King" <peff@peff.net>, "Ævar Arnfjörð" <avarab@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>,
"Brian Gernhardt" <brian@gernhardtsoftware.com>,
"git@vger.kernel.org List" <git@vger.kernel.org>
Subject: Re: t5541: Bad file descriptor
Date: Thu, 5 May 2011 13:59:36 -0400 [thread overview]
Message-ID: <BANLkTi=y+34s+yO9LVuiUxB5Xz3v7Pc2Mw@mail.gmail.com> (raw)
In-Reply-To: <BANLkTin8YUwoMmxXLske=5nuvW+idBOuig@mail.gmail.com>
On Thu, May 5, 2011 at 7:18 AM, Sverre Rabbelier <srabbelier@gmail.com> wrote:
> On Thu, May 5, 2011 at 08:16, Jeff King <peff@peff.net> wrote:
>> OK, embarrassing. 09c9957 completely breaks smart http pushing. My
>> testing of Johannes' patch was completely focused on the error case, and
>> I didn't have a single test for the non-error case. And on top of that,
>> we _have_ nice tests in the test suite to catch this, but obviously
>> neither I, nor Johannes, nor Junio were running them (because they need
>> apache installed and GIT_TEST_HTTPD set).
>
> Wasn't someone, I _think_ Ævar, or maybe Avery, (I could be totally
> wrong) running a buildbot of git.git on various platforms? If so,
> maybe they can turn on these tests since they aren't often run?
I was running one, didn't think anybody cared about it though. Please
point me at the necessary docs for this test and I can set up a new
one in my copious spare time (tm). I can't promise to monitor it
though, so that might be more of a problem :) gitbuilder does produce
rss feeds that are easy to track.
Have fun,
Avery
next prev parent reply other threads:[~2011-05-05 18:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-05 4:49 t5541: Bad file descriptor Brian Gernhardt
2011-05-05 5:35 ` Junio C Hamano
2011-05-05 5:46 ` Jeff King
2011-05-05 6:16 ` Jeff King
2011-05-05 11:18 ` Sverre Rabbelier
2011-05-05 17:59 ` Avery Pennarun [this message]
2011-05-05 18:51 ` Sverre Rabbelier
2011-05-09 14:50 ` Jeff King
2011-05-05 6:18 ` Jeff King
2011-05-05 6:57 ` Brian Gernhardt
2011-05-05 20:42 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=y+34s+yO9LVuiUxB5Xz3v7Pc2Mw@mail.gmail.com' \
--to=apenwarr@gmail.com \
--cc=avarab@gmail.com \
--cc=brian@gernhardtsoftware.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).