From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
To: Fredrik Gustafsson <iveqy@iveqy.com>
Cc: raible@nextest.com, jens.lehmann@web.de, hvoigt@hvoigt.net,
git@vger.kernel.org, gitster@pobox.com
Subject: Re: [RFC] status - don't show gitdir
Date: Thu, 30 Jun 2011 19:32:20 +0700 [thread overview]
Message-ID: <BANLkTikCmWLar4ztZgrWdB-md2X3bUxATg@mail.gmail.com> (raw)
In-Reply-To: <1309434388-3536-1-git-send-email-iveqy@iveqy.com>
On Thu, Jun 30, 2011 at 6:46 PM, Fredrik Gustafsson <iveqy@iveqy.com> wrote:
> When gitdir is inside the working dir, don't show it as a untracked
> directory.
read_directory_recursive() and friends ignore .git by default. I think
if you want to ignore the directory that .git file points to, you
should update there. I'm too lazy to check the code (my
read_directory_recursive is heavily modified currently), but I think
it does not check file type for .git entries now.
But if we step back a bit, why do you want git to automatically ignore
dirs that .git file points to? .git files are used to save real repo
somewhere safe, e.g. outside working directory. You do not handle
another case in your patch, where .git is a real symlink. In both
cases, it's not hard to add "real-git-dir" to .git/info/excludes.
--
Duy
next prev parent reply other threads:[~2011-06-30 12:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-30 9:04 Should 'git status' understand a .git containing "gitdir: dir"? Eric Raible
2011-06-30 11:46 ` [RFC] status - don't show gitdir Fredrik Gustafsson
2011-06-30 12:32 ` Nguyen Thai Ngoc Duy [this message]
2011-06-30 15:49 ` Should 'git status' understand a .git containing "gitdir: dir"? Junio C Hamano
2011-06-30 16:48 ` Eric Raible
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTikCmWLar4ztZgrWdB-md2X3bUxATg@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hvoigt@hvoigt.net \
--cc=iveqy@iveqy.com \
--cc=jens.lehmann@web.de \
--cc=raible@nextest.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).