From: Felipe Contreras <felipe.contreras@gmail.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: git@vger.kernel.org, "SZEDER Gábor" <szeder@ira.uka.de>
Subject: Re: [PATCH v5 0/2] git-completion: fix zsh support
Date: Tue, 10 May 2011 13:48:35 +0300 [thread overview]
Message-ID: <BANLkTikJbo2QGVsJ+6vqyg4n_9Qy17NbZg@mail.gmail.com> (raw)
In-Reply-To: <20110510025529.GA26619@elie>
On Tue, May 10, 2011 at 5:55 AM, Jonathan Nieder <jrnieder@gmail.com> wrote:
> As promised, here are two patches. No doubt I have done all sorts
> of horrible things to ruin them. Sorry about that; thoughts,
> improvements, bug reports welcome.
>
> Felipe Contreras (1):
> completion: suppress zsh's special 'words' variable
>
> Jonathan Nieder (1):
> completion: move private shopt shim for zsh to __git_ namespace
These two patches are not related. I don't see why they are on the
same patch set. I thought the idea was to have two patch sets:
* Important fix:
completion: suppress zsh's special 'words' variable
* Cleanups and improvements:
completion: don't modify the $cur variable in completion functions
completion: remove unnecessary _get_comp_words_by_ref() invocations
completion: move private shopt shim for zsh to __git_ namespace
--
Felipe Contreras
next prev parent reply other threads:[~2011-05-10 10:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-09 20:45 [PATCH v3 (for maint)] git-completion: fix zsh support Felipe Contreras
2011-05-09 21:13 ` Jonathan Nieder
2011-05-09 22:08 ` Felipe Contreras
2011-05-09 22:14 ` [PATCH v4 " Felipe Contreras
2011-05-09 22:53 ` Jonathan Nieder
2011-05-09 23:13 ` Felipe Contreras
2011-05-09 23:28 ` Jonathan Nieder
2011-05-09 23:58 ` Felipe Contreras
2011-05-09 23:25 ` Junio C Hamano
2011-05-09 23:35 ` Jonathan Nieder
2011-05-10 2:55 ` [PATCH v5 0/2] " Jonathan Nieder
2011-05-10 2:59 ` [PATCH 1/2] completion: suppress zsh's special 'words' variable Jonathan Nieder
2011-05-10 3:17 ` Jonathan Nieder
2011-05-10 11:43 ` Felipe Contreras
2011-05-10 11:29 ` Felipe Contreras
2011-05-10 3:00 ` [PATCH 2/2] completion: move private shopt shim for zsh to __git_ namespace Jonathan Nieder
2011-05-10 10:48 ` Felipe Contreras [this message]
2011-05-10 2:04 ` [PATCH v3 (for maint)] git-completion: fix zsh support Jonathan Nieder
2011-05-10 10:44 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTikJbo2QGVsJ+6vqyg4n_9Qy17NbZg@mail.gmail.com \
--to=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).