git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: James Blackburn <jamesblackburn@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>, Jakub Narebski <jnareb@gmail.com>,
	git@vger.kernel.org
Subject: Re: git log --follow doesn't follow a rename over a merge
Date: Thu, 16 Jun 2011 19:41:14 +0100	[thread overview]
Message-ID: <BANLkTikMNYyV40XM26rc6Ov6ZYO643mukA@mail.gmail.com> (raw)
In-Reply-To: <7vy611hd38.fsf@alter.siamese.dyndns.org>

On 16 June 2011 18:59, Junio C Hamano <gitster@pobox.com> wrote:
>   past ---o----o-----o-----o-----o-----o-----o-----o--- now
>            \                          /
>             o----*----o----o----*----o
>                  ^added         ^removed
>
> then the merges are simplified away and you would not see it.
>
> Perhaps simplify-merges option may help.

Magic, that works!

What I don't get is that I believe the file is removed in the 'merge'
commit 'X', which is reachable from master, not in the feature branch:

 2002 ---o----o-----o-----o-----X-----o-----o-----o--- 2011         (CDT)
                                    /
 2006 ---o----o-----o-----o--   (2009)                                  (DSF)

> git log --simplify-merges --oneline -- plugins/org.eclipse.dd.dsf.debug/src/org/eclipse/dd/dsf/debug/service/IBreakpoints.java
2f1c904 [memory] DSDP-DD -> CDT initial commit
5b47187 Migrated DSF and DSF-GDB to the CDT project.
10580b5 Updated copyright statements.
...

So 5b48718 is X, and the file exists in the DSF parent of X: c1e6da2

I think 2f1c904 is entirely wrong too -- it's another graft I've done,
to a different repo, which isn't to do with DSF, and doesn't contain
IBreakpoints.java:
 > git show 2f1c904:plugins/org.eclipse.dd.dsf.debug/src/org/eclipse/dd/dsf/debug/service/IBreakpoints.java
fatal: Path 'plugins/org.eclipse.dd.dsf.debug/src/org/eclipse/dd/dsf/debug/service/IBreakpoints.java'
does not exist in '2f1c904'

Given the file was removed during my 'merge' graft in commit X,
shouldn't it be visible  in log without --simplify-merges?

Cheers,
James

  parent reply	other threads:[~2011-06-16 18:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-15 22:41 git log --follow doesn't follow a rename over a merge James Blackburn
2011-06-16 13:25 ` Jakub Narebski
2011-06-16 13:31   ` James Blackburn
2011-06-16 17:01     ` James Blackburn
2011-06-16 17:45       ` Jeff King
2011-06-16 17:34     ` Jeff King
2011-06-16 17:59       ` Junio C Hamano
2011-06-16 18:15         ` Jeff King
2011-06-16 19:41           ` James Blackburn
2011-06-16 18:41         ` James Blackburn [this message]
2011-06-16 19:36           ` Junio C Hamano
2011-06-16 21:29             ` James Blackburn
2011-06-16 22:14           ` James Blackburn
2011-06-16 18:21       ` James Blackburn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTikMNYyV40XM26rc6Ov6ZYO643mukA@mail.gmail.com \
    --to=jamesblackburn@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jnareb@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).