git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Philippe Vaucher <philippe.vaucher@gmail.com>
To: git@vger.kernel.org
Subject: Re: git rebase --interactive commits order
Date: Wed, 11 May 2011 20:45:56 +0200	[thread overview]
Message-ID: <BANLkTikMo_VLMc2zxezgX_mjCaB8C2LgBw@mail.gmail.com> (raw)
In-Reply-To: <7v39klgng7.fsf@alter.siamese.dyndns.org>

> You start 'rebase' (without --reverse); it stops with conflict.  Now what
> should happen when you say 'rebase --reverse --continue' now?  Does it
> error out because you are not allowed to change your mind once you
> started?

I had a long answer explaining it all but Richard beat me to it, and
his answer is pretty much exactly what I meant. Rebase wouldn't even
change, only the order of which stuffs are displayed in the editor.

> I am not saying that these small details cannot be worked out. I am saying
> that you would need to spend a lot of effort to take care of the details
> to avoid making it confusing to the users.  And I am also saying that it
> is not even worth wasting the brainpower spent discussing these in this
> thread, if the only "benefit" resulting from it is to add an option that
> allows some people to have an ordered list of things to do "First I do
> this and then I do that" that has to be read backwards. Why spend extra
> effort only to introduce something confusing?

Well for us it's the current way that is confusing (and probably for a
lot of other users too, especially new ones). It's what we suggest
that would (imho) make it non-confusing... I'd very much like the
"benefit" from this discussion to be a change of default in how rebase
-i display commits, but as for some people having it reversed seems to
be a strong no-go, it seems the only rational thing we can do is offer
a --reverse option so the people used to the current way are happy.

If even adding an option is asking for too much, then we might resort
to EDITOR tricks and whatnot. You made me realise I could write a vim
script that offers the fonctionality I need without even touching git,
but it'd work for me only. I fail to see the problem with adding an
option which would simplify the life of many people and isn't invasive
for the others.

Philippe

  parent reply	other threads:[~2011-05-11 18:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-09  9:30 git rebase --interactive commits order Philippe Vaucher
2011-05-09 10:10 ` David
2011-05-09 23:31   ` Steven E. Harris
2011-05-10 22:20     ` Philippe Vaucher
2011-05-10 22:30       ` Sverre Rabbelier
2011-05-10 23:26         ` Junio C Hamano
2011-05-11 15:43           ` Richard Peterson
2011-05-11 17:24             ` Junio C Hamano
2011-05-11 18:39               ` Richard Peterson
2011-05-11 18:45               ` Philippe Vaucher [this message]
2011-05-13 17:51               ` Nicolas Sebrecht
2011-05-14 10:58                 ` Philippe Vaucher
2011-05-10 22:56       ` Junio C Hamano
2011-05-10 23:05         ` Philippe Vaucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTikMo_VLMc2zxezgX_mjCaB8C2LgBw@mail.gmail.com \
    --to=philippe.vaucher@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).