From: Elazar Leibovich <elazarl@gmail.com>
To: Tim Mazid <timmazid@hotmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: Supporting "-v" option for git-log
Date: Wed, 25 May 2011 14:28:12 +0300 [thread overview]
Message-ID: <BANLkTikT4s+Twfip2g7Zo-XcML1Wbd3qBg@mail.gmail.com> (raw)
In-Reply-To: <SNT124-W5207D5461CD80509763B79C4740@phx.gbl>
On Wed, May 25, 2011 at 2:21 PM, Tim Mazid <timmazid@hotmail.com> wrote:
>
> Well, personally, I've never used the --grep option. I pipe it through
> grep, where I can supply options such as -v.
But then you must use single-line commits output. Which is
inconvenient if you want to read all the commit message.
> However, if the --grep
> option already exists, then it does make sense to allow users to use
> options they would normally be able to with grep.
>
> As for the syntax, that seems like a good idea on the surface, but
> how would you go about supporting other grep options? Such as
> "-i"?
Now that I think of it, we already have the '--not' option for
revision specifiers. Why won't we use it for grep patterns? That way
-v will not be overloaded (it usually means verbose). For example
git log --all --not --grep A --grep B
Would mean find all commits without A and with B, in SQL "SELECT *
FROM COMMITS WHERE message NOT LIKE '%A%' AND message LIKE '%B%'".
next prev parent reply other threads:[~2011-05-25 11:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-25 9:40 Supporting "-v" option for git-log Elazar Leibovich
2011-05-25 11:05 ` Tim Mazid
2011-05-25 11:14 ` Elazar Leibovich
2011-05-25 11:21 ` Tim Mazid
2011-05-25 11:24 ` Tim Mazid
2011-05-25 11:28 ` Elazar Leibovich [this message]
2011-05-25 11:35 ` Tim Mazid
2011-05-25 11:40 ` Elazar Leibovich
2011-05-25 13:29 ` Jeff King
2011-05-25 13:53 ` Jakub Narebski
2011-05-25 15:11 ` Jeff King
2011-05-25 16:38 ` Jakub Narebski
2011-05-25 17:32 ` Junio C Hamano
2011-05-25 20:01 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTikT4s+Twfip2g7Zo-XcML1Wbd3qBg@mail.gmail.com \
--to=elazarl@gmail.com \
--cc=git@vger.kernel.org \
--cc=timmazid@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).