git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Michael J Gruber <git@drmicha.warpmail.net>
Subject: Re: [PATCH 2/5] Replace has_wildcard with PATHSPEC_NOGLOB
Date: Sun, 10 Apr 2011 14:23:21 +0700	[thread overview]
Message-ID: <BANLkTikT7pz_nSJRAOb3rtYePBuVc2YX0Q@mail.gmail.com> (raw)
In-Reply-To: <7vbp0fylox.fsf@alter.siamese.dyndns.org>

2011/4/10 Junio C Hamano <gitster@pobox.com>:
>> +/*
>> + * Magic pathspec
>> + *
>> + * NEEDSWORK: These need to be moved to dir.h or even to a new
>> + * pathspec.h when we restructure get_pathspec() users to use the
>> + * "struct pathspec" interface.
>> + *
>> + * Possible future magic semantics include stuff like:
>> + *
>> + *   { PATHSPEC_NOGLOB, '!', "noglob" },
>> + *   { PATHSPEC_RECURSIVE, '*', "recursive" },
>> + *   { PATHSPEC_REGEXP, '\0', "regexp" },
>> + *
>> + */
>
> Gaah, why did you butcher this to heve only the whole comment and struct
> type declaration here, without moving the "Possible future magic" comment
> that clearly belongs to the structure definition you still have in dir.c
> to where it belongs?  Also if NOGLOB is no longer "Possible future", why
> is it still here?

Carelessness, I guess. Will move it (with the NOGLOB future line
removed) to dir.c, close to get_pathspec().
-- 
Duy

  reply	other threads:[~2011-04-10  7:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-09 16:54 [PATCH 0/5] New get_pathspec() Nguyễn Thái Ngọc Duy
2011-04-09 16:54 ` [PATCH 1/5] Rename functions in preparation for get_pathspec() restructure Nguyễn Thái Ngọc Duy
2011-04-09 16:54 ` [PATCH 2/5] Replace has_wildcard with PATHSPEC_NOGLOB Nguyễn Thái Ngọc Duy
2011-04-10  0:49   ` Junio C Hamano
2011-04-10  7:23     ` Nguyen Thai Ngoc Duy [this message]
2011-04-09 16:54 ` [PATCH 3/5] Convert prefix_pathspec() to produce struct pathspec_item Nguyễn Thái Ngọc Duy
2011-04-09 16:54 ` [PATCH 4/5] Implement new get_pathspec() Nguyễn Thái Ngọc Duy
2011-04-09 16:54 ` [PATCH 5/5] grep: convert to use the " Nguyễn Thái Ngọc Duy
2011-04-10  0:56   ` Junio C Hamano
2011-04-10  7:26     ` Nguyen Thai Ngoc Duy
2011-04-09 21:41 ` [PATCH 0/5] New get_pathspec() Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTikT7pz_nSJRAOb3rtYePBuVc2YX0Q@mail.gmail.com \
    --to=pclouds@gmail.com \
    --cc=git@drmicha.warpmail.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).