git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jérémie NIKAES" <jeremie.nikaes@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>,
	thomas@xteddy.org, git@vger.kernel.org
Subject: Re: Git-mediawiki : Encoding problems in perl
Date: Thu, 9 Jun 2011 00:36:58 +0200	[thread overview]
Message-ID: <BANLkTikTDPmvj4oepiJdFj9EpSTNpS_Prg@mail.gmail.com> (raw)
In-Reply-To: <20110608215130.GA13021@sigill.intra.peff.net>

2011/6/8 Jeff King <peff@peff.net>:
>
> But if you are parsing "diff", then yes, filenames with high-bit
> characters (or special characters like tab or double-quote) may be
> quoted C-style, and you should be unquoting them. Or, as Matthieu
> suggested, use "-z" to get a NUL-terminated, non-quoted version.

Yes, we are parsing "diff". The -z helped a lot with non-iso characters.
Everything seems to be working fine now without using uri_escape. The
problem is, as Matthieu said, different file systems may handle these
characters in file names differently, so in the long run it could be
better to use uri_escape / uri_unescape.

The problem I run into now is that we are using
use encoding 'utf-8'
as Jakub suggested.
Using this mode, when you uri_escape and uri_unescape a string, you
don't get the original string. I must be missing something but my head
is kind of fuzzy with all the different existing methods to encode
things in utf8 and it is getting pretty late.

Thanks a lot to everyone who helped today, a RFC patch should follow tomorrow.

-- 
Jérémie Nikaes

  reply	other threads:[~2011-06-08 22:37 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-08 13:45 Git-mediawiki : Encoding problems in perl Jérémie NIKAES
2011-06-08 14:37 ` Steffen Daode Nurpmeso
2011-06-08 15:01 ` Jeff King
2011-06-08 15:37   ` Matthieu Moy
2011-06-08 15:45     ` Jeff King
2011-06-08 15:46     ` Jérémie NIKAES
2011-06-08 15:58       ` Matthieu Moy
2011-06-08 16:15         ` Jérémie NIKAES
2011-06-08 16:18           ` Jeff King
2011-06-08 16:26             ` Jérémie NIKAES
2011-06-08 16:27           ` Matthieu Moy
2011-06-08 16:30             ` Jérémie NIKAES
2011-06-08 17:07           ` Jakub Narebski
2011-06-08 17:11           ` Matthieu Moy
2011-06-08 18:03             ` Jérémie NIKAES
2011-06-08 18:20               ` Matthieu Moy
2011-06-08 21:51               ` Jeff King
2011-06-08 22:36                 ` Jérémie NIKAES [this message]
2011-06-08 17:04 ` Jakub Narebski
2011-06-08 17:59   ` Jérémie NIKAES

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTikTDPmvj4oepiJdFj9EpSTNpS_Prg@mail.gmail.com \
    --to=jeremie.nikaes@gmail.com \
    --cc=Matthieu.Moy@grenoble-inp.fr \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=thomas@xteddy.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).