Re: [PATCH v4 (for maint)] git-completion: fix zsh support

[Felipe Contreras <felipe.contreras@gmail.com>]

On Tue, May 10, 2011 at 2:28 AM, Jonathan Nieder <jrnieder@gmail.com> wrote:
> Felipe Contreras wrote:
>> On Tue, May 10, 2011 at 1:53 AM, Jonathan Nieder <jrnieder@gmail.com> wrote:
>
>>>  - the fix in sg/completion-updates is less likely to be broken by
>>>   future changes in the bashcompinit library.
>>
>> How exactly?
>
> Because there remains the possibility that functions from bashcompinit
> will make use of the $words variable.  I have said this about three
> times.  It is not very likely, assuming the zsh developers want to keep
> supporting that fix (and I think they should), but the chance is there.

And I even wrote a test to show you that's not the case:
http://article.gmane.org/gmane.comp.version-control.git/172963

Now, can you modify my test to explain how *exactly* zsh folks can
screw my patch up?

>>>  - this fix is conceptually simpler.  In a way, the fix in
>>>   sg/completion-updates only works by accident.
>>
>> You are missing other advantages:
>
> Sorry, I should have prefaced the above with "in my opinion".  And to
> be clear, I am not saying this fix should not be applied; I am just
> explaining the trade-offs as I understand them.
>
> The reason I asked for another opinion is that I find it hard to be
> objective in this case, because of another consideration I didn't
> mention: each moment I have been spending on this is an exercise in
> frustration.

Well, don't :) Just ask yourself this question: is the patch good
enough? If not, send your own version.

Personally I think the latest version of the patch clearly explains
what it is doing, and why. It even has comments on the code, which the
other alternative doesn't.

-- 
Felipe Contreras