git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Git Mailing List <git@vger.kernel.org>,
	Junio C Hamano <gitster@pobox.com>
Subject: Documentation doesn't build anymore on old asciidoc due to i18n series
Date: Sat, 28 May 2011 13:40:22 +0200	[thread overview]
Message-ID: <BANLkTikjfyxAzLu2e5aJFVhgKq8UBiJAQw@mail.gmail.com> (raw)

I can submit a patch for this later, just thought I'd note it and
solicit feedback on the best solution to this.

On my Debian box with asciidoc 8.6.4 Git builds just fine from master.

But on a Centos 5.5 box with asciidoc 8.2.5 I get:

    rm -f git-sh-i18n--envsubst.html+ git-sh-i18n--envsubst.html && \
            asciidoc -b xhtml11 -d manpage -f asciidoc.conf \
                     -a asciidoc7compatible -a no-inline-literal -a
git-asciidoc-no-roff -agit_version=1.7.5.3.367.ga9930 -o
git-sh-i18n--envsubst.html+ git-sh-i18n--envsubst.txt && \
            mv git-sh-i18n--envsubst.html+ git-sh-i18n--envsubst.html
    ERROR: git-sh-i18n--envsubst.txt: line 9: second section must be
named SYNOPSIS
    make[1]: *** [git-sh-i18n--envsubst.html] Error 1

The solution is obvious: just add a SYNOPSIS section for
consistency. I'll do that later, unless we want to provide some option
(which old asciidoc may or may not support) to not have a SYNOPSIS
there, which we arguably can just omit for purely internal tooling
like this.

I'll submit patches soon for adding a SYNOPSIS unless we want to go
that route.

             reply	other threads:[~2011-05-28 11:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-28 11:40 Ævar Arnfjörð Bjarmason [this message]
2011-05-29 11:00 ` [PATCH] git-sh-i18n--envsubst: add SYNOPSIS section to the documentation Ævar Arnfjörð Bjarmason
2011-05-30  8:09   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTikjfyxAzLu2e5aJFVhgKq8UBiJAQw@mail.gmail.com \
    --to=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).