From: Erik Faye-Lund <kusmabite@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 6/6] zlib: zlib can only process 4GB at a time
Date: Sun, 12 Jun 2011 22:43:42 +0200 [thread overview]
Message-ID: <BANLkTikmLDZj2qdkmF-kBUkB33o9EjtBpg@mail.gmail.com> (raw)
In-Reply-To: <1307736948-16956-7-git-send-email-gitster@pobox.com>
On Fri, Jun 10, 2011 at 10:15 PM, Junio C Hamano <gitster@pobox.com> wrote:
> The size of objects we read from the repository and data we try to put
> into the repository are represented in "unsigned long", so that on larger
> architectures we can handle objects that weigh more than 4GB.
shouldn't this be "size_t" instead of "unsigned long"? "unsigned long"
is 32bit on Win64, whereas size_t is 64bit:
http://msdn.microsoft.com/en-us/library/s3f49ktz(v=vs.80).aspx
http://msdn.microsoft.com/en-us/library/aa384083(VS.85).aspx
next prev parent reply other threads:[~2011-06-12 20:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-10 20:15 [PATCH 0/6] zlib only processes 4GB at a time Junio C Hamano
2011-06-10 20:15 ` [PATCH 1/6] zlib: refactor error message formatter Junio C Hamano
2011-06-10 20:15 ` [PATCH 2/6] zlib: wrap remaining calls to direct inflate/inflateEnd Junio C Hamano
2011-06-10 20:15 ` [PATCH 3/6] zlib: wrap inflateInit2 used to accept only for gzip format Junio C Hamano
2011-06-10 20:15 ` [PATCH 4/6] zlib: wrap deflate side of the API Junio C Hamano
2011-06-10 22:23 ` Thiago Farina
2011-06-10 23:00 ` Junio C Hamano
2011-06-10 20:15 ` [PATCH 5/6] zlib: wrap deflateBound() too Junio C Hamano
2011-06-10 20:15 ` [PATCH 6/6] zlib: zlib can only process 4GB at a time Junio C Hamano
2011-06-12 20:43 ` Erik Faye-Lund [this message]
2011-06-12 21:33 ` Junio C Hamano
2011-06-12 21:46 ` Matthieu Moy
2011-06-13 11:17 ` Erik Faye-Lund
2011-06-13 11:52 ` Jonathan Nieder
2011-06-13 11:56 ` Junio C Hamano
2011-06-10 23:47 ` [PATCH 7/6] zlib: allow feeding more than 4GB in one go Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTikmLDZj2qdkmF-kBUkB33o9EjtBpg@mail.gmail.com \
--to=kusmabite@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).