git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Thiago Farina <tfransosi@gmail.com>,
	Jonathan Nieder <jrnieder@gmail.com>,
	Git Mailing List <git@vger.kernel.org>,
	Nguyen Thai Ngoc Duy <pclouds@gmail.com>,
	Stephen Boyd <bebarino@gmail.com>
Subject: Re: [RFC PATCH] git-send-email: Validate recipient_cmd (to-cmd, cc-cmd) addresses
Date: Thu, 21 Apr 2011 00:29:24 +0200	[thread overview]
Message-ID: <BANLkTikuC1V1U-c0wyThOZAn6gVXr7S_cQ@mail.gmail.com> (raw)
In-Reply-To: <1303336253.24766.34.camel@Joe-Laptop>

On Wed, Apr 20, 2011 at 23:50, Joe Perches <joe@perches.com> wrote:
> +       my ($recipient_name, $recipient_addr) = ($recipient =~ /^\s*(.*?)\s*(<[^>]+>)/);

In Perl you can write (<.*?>) instead of (<[^>]+>)

> +               if ($recipient =~ /^\s*(.+\@\S*).*$/) {

If this program doesn't have some extract_emails_from_string()
function already it probably should.

  reply	other threads:[~2011-04-20 22:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-17 22:32 problem when using --cc-cmd Thiago Farina
2011-04-19 21:52 ` Jonathan Nieder
2011-04-20  3:03   ` Joe Perches
2011-04-20 15:45     ` Thiago Farina
2011-04-20 19:48       ` Joe Perches
2011-04-20 21:50       ` [RFC PATCH] git-send-email: Validate recipient_cmd (to-cmd, cc-cmd) addresses Joe Perches
2011-04-20 22:29         ` Ævar Arnfjörð Bjarmason [this message]
2011-04-20 22:45           ` Joe Perches
2011-04-20 22:50             ` Ævar Arnfjörð Bjarmason
2011-04-20 23:01               ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTikuC1V1U-c0wyThOZAn6gVXr7S_cQ@mail.gmail.com \
    --to=avarab@gmail.com \
    --cc=bebarino@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=joe@perches.com \
    --cc=jrnieder@gmail.com \
    --cc=pclouds@gmail.com \
    --cc=tfransosi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).