From: Shawn Pearce <spearce@spearce.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git <git@vger.kernel.org>
Subject: blame --reverse selecting wrong commit
Date: Sun, 29 May 2011 19:21:33 -0700 [thread overview]
Message-ID: <BANLkTikuFEg686VH_RojEe-zmBZRBOx6eA@mail.gmail.com> (raw)
Although blame shows Stefan Lay removed the block in commit 05fa1713,
this isn't what happened. It was actually removed in commit 2302a6d3
by Christian Halstrick. It looks like blame gets confused around this
section of the JGit history.
Repository URL: git://egit.eclipse.jgit/jgit.git
$ git blame -L 1080, --reverse 40fa75feb..master --
org.eclipse.jgit.test/tst/org/eclipse/jgit/storage/file/RefDirectoryTest.java
283a60d1 (Shawn O. Pearce 2011-05-26 17:25:59 -0700 1080) }
05fa1713 (Stefan Lay 2011-05-24 01:38:59 -0700 1081)
05fa1713 (Stefan Lay 2011-05-24 01:38:59 -0700 1082) /**
05fa1713 (Stefan Lay 2011-05-24 01:38:59 -0700 1083) *
Kick the timestamp of a local file.
05fa1713 (Stefan Lay 2011-05-24 01:38:59 -0700 1084) * <p>
05fa1713 (Stefan Lay 2011-05-24 01:38:59 -0700 1085) * We
shouldn't have to make these method calls. The cache is using file
05fa1713 (Stefan Lay 2011-05-24 01:38:59 -0700 1086) *
system timestamps, and on many systems unit tests run faster than the
05fa1713 (Stefan Lay 2011-05-24 01:38:59 -0700 1087) *
modification clock. Dumping the cache after we make an edit behind
05fa1713 (Stefan Lay 2011-05-24 01:38:59 -0700 1088) *
RefDirectory's back allows the tests to pass.
05fa1713 (Stefan Lay 2011-05-24 01:38:59 -0700 1089) *
05fa1713 (Stefan Lay 2011-05-24 01:38:59 -0700 1090) * @param name
05fa1713 (Stefan Lay 2011-05-24 01:38:59 -0700 1091) *
the file in the repository to force a time change on.
05fa1713 (Stefan Lay 2011-05-24 01:38:59 -0700 1092) */
05fa1713 (Stefan Lay 2011-05-24 01:38:59 -0700 1093)
private void BUG_WorkAroundRacyGitIssues(String name) {
--
Shawn.
next reply other threads:[~2011-05-30 2:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-30 2:21 Shawn Pearce [this message]
2011-05-30 2:33 ` blame --reverse selecting wrong commit Shawn Pearce
2011-05-30 3:11 ` Shawn Pearce
2011-05-30 6:47 ` Junio C Hamano
2011-05-30 17:57 ` Shawn Pearce
2011-05-30 20:01 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTikuFEg686VH_RojEe-zmBZRBOx6eA@mail.gmail.com \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).