From: Shawn Pearce <spearce@spearce.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Nicolas Pitre <nico@fluxnic.net>,
Holger Hellmuth <hellmuth@ira.uka.de>,
Nguyen Thai Ngoc Duy <pclouds@gmail.com>,
Git Mailing List <git@vger.kernel.org>,
Alif Wahid <alif.wahid@gmail.com>
Subject: Re: Git exhausts memory.
Date: Tue, 5 Apr 2011 18:19:30 -0400 [thread overview]
Message-ID: <BANLkTim-6L1ZeaPT3tVWmyhj-rX1iURQ3g@mail.gmail.com> (raw)
In-Reply-To: <7vmxk4l4yb.fsf@alter.siamese.dyndns.org>
On Tue, Apr 5, 2011 at 18:16, Junio C Hamano <gitster@pobox.com> wrote:
> Nicolas Pitre <nico@fluxnic.net> writes:
>
>>> > This is only implemented inside of fast-import. pack-objects does not
>>> > honor this variable.
>>>
>>> Do you mean perhaps we should?
>>
>> Yes.
>>
>> Acked-by: Nicolas Pitre <nico@fluxnic.net>
>
> I actually was somewhat unhappy to use uintmax_t type in the public header
> for some reason I cannot quite explain (perhaps religious), and was hoping
> somebody with more sanity than myself would stop me or show me a better
> way.
unsigned long? Without even looking at the source, I bet that is the
type used by pack-objects for the size member that you are comparing
against.
--
Shawn.
next prev parent reply other threads:[~2011-04-05 22:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-02 5:01 Git exhausts memory Alif Wahid
2011-04-02 15:05 ` Nicolas Pitre
2011-04-03 9:15 ` Alif Wahid
2011-04-03 15:18 ` Nicolas Pitre
2011-04-04 12:52 ` Alif Wahid
2011-04-04 14:57 ` Nguyen Thai Ngoc Duy
2011-04-05 2:22 ` David Fries
2011-04-05 4:35 ` Alif Wahid
2011-04-05 11:13 ` Nguyen Thai Ngoc Duy
2011-04-05 11:26 ` Alif Wahid
2011-04-05 16:48 ` Holger Hellmuth
2011-04-05 17:06 ` Shawn Pearce
2011-04-05 17:44 ` Junio C Hamano
2011-04-05 20:56 ` Nicolas Pitre
2011-04-05 22:16 ` Junio C Hamano
2011-04-05 22:19 ` Shawn Pearce [this message]
2011-04-06 0:34 ` Nicolas Pitre
2011-04-06 15:51 ` Jay Soffian
2011-04-06 16:33 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTim-6L1ZeaPT3tVWmyhj-rX1iURQ3g@mail.gmail.com \
--to=spearce@spearce.org \
--cc=alif.wahid@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hellmuth@ira.uka.de \
--cc=nico@fluxnic.net \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).