From: Thiago Farina <tfransosi@gmail.com>
To: Namhyung Kim <namhyung@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH v2 1/3] blame: add --abbrev command line option
Date: Tue, 5 Apr 2011 23:46:19 -0300 [thread overview]
Message-ID: <BANLkTim8bR1Z5sQCtVeqCJcCh_wuQxCvJQ@mail.gmail.com> (raw)
In-Reply-To: <1302056452-5387-1-git-send-email-namhyung@gmail.com>
On Tue, Apr 5, 2011 at 11:20 PM, Namhyung Kim <namhyung@gmail.com> wrote:
> Signed-off-by: Namhyung Kim <namhyung@gmail.com>
> ---
> builtin/blame.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/builtin/blame.c b/builtin/blame.c
> index f6b03f7..253b480 100644
> --- a/builtin/blame.c
> +++ b/builtin/blame.c
> @@ -41,6 +41,7 @@ static int reverse;
> static int blank_boundary;
> static int incremental;
> static int xdl_opts;
> +static int abbrev = 8;
>
> static enum date_mode blame_date_mode = DATE_ISO8601;
> static size_t blame_date_width;
> @@ -1670,7 +1671,7 @@ static void emit_other(struct scoreboard *sb, struct blame_entry *ent, int opt)
> cp = nth_line(sb, ent->lno);
> for (cnt = 0; cnt < ent->num_lines; cnt++) {
> char ch;
> - int length = (opt & OUTPUT_LONG_OBJECT_NAME) ? 40 : 8;
> + int length = (opt & OUTPUT_LONG_OBJECT_NAME) ? 40 : abbrev;
Should this 40 be a constant?
next prev parent reply other threads:[~2011-04-06 2:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-06 2:20 [PATCH v2 1/3] blame: add --abbrev command line option Namhyung Kim
2011-04-06 2:20 ` [PATCH v2 2/3] blame: honor core.abbrev Namhyung Kim
2011-04-06 2:20 ` [PATCH v2 3/3] Documentation: add --abbrev option to the man page of git blame Namhyung Kim
2011-04-06 2:46 ` Thiago Farina [this message]
2011-04-06 3:18 ` [PATCH v2 1/3] blame: add --abbrev command line option Junio C Hamano
2011-04-06 11:06 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTim8bR1Z5sQCtVeqCJcCh_wuQxCvJQ@mail.gmail.com \
--to=tfransosi@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=namhyung@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).