From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>,
git@vger.kernel.org, Michael J Gruber <git@drmicha.warpmail.net>
Subject: Re: [PATCH 2/4] add -u: get rid of "treewideupdate" configuration
Date: Sat, 9 Apr 2011 11:58:09 +0700 [thread overview]
Message-ID: <BANLkTimCbr+hnJNGWDBVbjZKEBDW1KR4=g@mail.gmail.com> (raw)
In-Reply-To: <7vaag01gdl.fsf@alter.siamese.dyndns.org>
On Sat, Apr 9, 2011 at 6:18 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Also make ':' without anything else to mean "there is no pathspec". This
> would allow differences between "git log" and "git log ." run from the top
> level of the working tree (the latter simplifies no-op commits away from
> the history) to be expressed from a subdirectory by saying "git log :".
The intention is good, but reality may need more work. I assume that
"git add -u :" is equivalent to "git add -u" (or "git add -u ." to be
precise). Unfortunately, cmd_add() checks argc for no arguments to
turn "add -u <nothing>" to "add -u .", not the result from
get_pathspec(). It can be fixed. Just heads up as there can be similar
traps elsewhere.
--
Duy
next prev parent reply other threads:[~2011-04-09 4:58 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-07 1:16 [PATCH 0/4] Redoing the "add -u" migration plan Junio C Hamano
2011-04-07 1:16 ` [PATCH 1/4] magic pathspec: add tentative ":/path/from/top/level" pathspec support Junio C Hamano
2011-04-07 1:40 ` Junio C Hamano
2011-04-07 13:09 ` Nguyen Thai Ngoc Duy
2011-04-07 18:28 ` Junio C Hamano
2011-04-08 11:39 ` Nguyen Thai Ngoc Duy
2011-04-07 13:23 ` Nguyen Thai Ngoc Duy
2011-04-07 16:18 ` Junio C Hamano
2011-04-08 12:00 ` Nguyen Thai Ngoc Duy
2011-04-08 15:05 ` Junio C Hamano
2011-04-08 15:39 ` Nguyen Thai Ngoc Duy
2011-04-08 16:37 ` Junio C Hamano
2011-04-08 17:02 ` Nguyen Thai Ngoc Duy
2011-04-07 1:16 ` [PATCH 2/4] add -u: get rid of "treewideupdate" configuration Junio C Hamano
2011-04-08 17:54 ` Jeff King
2011-04-08 19:27 ` Junio C Hamano
2011-04-08 20:24 ` Jeff King
2011-04-08 22:22 ` Junio C Hamano
2011-04-08 22:32 ` Jeff King
2011-04-08 22:37 ` Junio C Hamano
2011-04-08 23:18 ` Junio C Hamano
2011-04-09 4:38 ` Nguyen Thai Ngoc Duy
2011-04-09 4:56 ` Junio C Hamano
2011-04-09 5:05 ` Nguyen Thai Ngoc Duy
2011-04-09 21:34 ` Junio C Hamano
2011-04-09 4:58 ` Nguyen Thai Ngoc Duy [this message]
2011-04-09 5:20 ` Junio C Hamano
2011-04-09 10:15 ` Nguyen Thai Ngoc Duy
2011-04-09 11:24 ` Nguyen Thai Ngoc Duy
2011-04-09 21:38 ` Junio C Hamano
2011-05-03 7:52 ` Nguyen Thai Ngoc Duy
2011-05-03 15:01 ` Junio C Hamano
2011-05-03 16:17 ` Nguyen Thai Ngoc Duy
2011-04-07 1:16 ` [PATCH 3/4] add: make "add -u/-A" update full tree without pathspec (step 2) Junio C Hamano
2011-04-07 1:16 ` [PATCH 4/4] add: make "add -u/-A" update full tree without pathspec (step 3) Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTimCbr+hnJNGWDBVbjZKEBDW1KR4=g@mail.gmail.com' \
--to=pclouds@gmail.com \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).