From: Linus Torvalds <torvalds@linux-foundation.org>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Junio C Hamano <gitster@pobox.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: Whitespace and ' '
Date: Fri, 27 May 2011 10:01:17 -0700 [thread overview]
Message-ID: <BANLkTimPfN6LQBhWj6rW3Zcm9JHPsMWsjA@mail.gmail.com> (raw)
In-Reply-To: <m262owhyuy.fsf@igel.home>
On Fri, May 27, 2011 at 9:50 AM, Andreas Schwab <schwab@linux-m68k.org> wrote:
>
> Is this a gmail thing?
Gmail on the sending side - quite possibly part of a reflowing thing,
especially with quoting. I send patches as attachments because gmail
is crap in this regard (and yes, I hate it, and I go back to alpine
for any bigger issues).
But on the receiving side? Sounds unlikely, since I've used gmail for
the last year to receive patches, and this is the first time I've seen
it.
And the sent email that had the issue this time implied mutt, not gmail.
Regardless, what took me by surprise was how (a) the patch applied
fine, (b) it _looked_ fine in all the normal tools, and (c) it just
didn't work.
Now, very arguably this is not a git issue at all. Having the odd nbsp
be more visible in my other tools would have been fine - either 'less'
showing it (the way it shows other control characters) or my terminal
making some visual distinction. That said, I think it's something that
git could perhaps protect against a bit.
Linus
next prev parent reply other threads:[~2011-05-27 17:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-26 21:12 Whitespace and ' ' Linus Torvalds
2011-05-26 21:57 ` Junio C Hamano
2011-05-26 22:08 ` Linus Torvalds
2011-05-27 16:50 ` Andreas Schwab
2011-05-27 17:01 ` Linus Torvalds [this message]
2011-05-27 18:31 ` Junio C Hamano
2011-05-27 19:15 ` Junio C Hamano
2011-05-27 21:14 ` Linus Torvalds
2011-05-27 22:47 ` Junio C Hamano
2011-05-27 22:48 ` [PATCH 1/3] ws.c: add a helper to format comma separated messages Junio C Hamano
2011-05-27 22:49 ` [PATCH 2/3] War on nbsp: a bit of retreat Junio C Hamano
2011-05-27 22:51 ` [PATCH 3/3] War on nbsp: Add "nbsp" whitespace breakage class Junio C Hamano
2011-05-28 1:31 ` [PATCH 4/3] War on nbsp: teach "git apply" to check and fix nbsp Junio C Hamano
2011-05-30 12:52 ` Whitespace and ' ' Daniel Nyström
2011-05-26 22:21 ` Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTimPfN6LQBhWj6rW3Zcm9JHPsMWsjA@mail.gmail.com \
--to=torvalds@linux-foundation.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).