From: Erik Faye-Lund <kusmabite@gmail.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Jeff King <peff@peff.net>, Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 1/2] Remove noreturn function pointers in usage.c
Date: Thu, 9 Jun 2011 23:13:56 +0200 [thread overview]
Message-ID: <BANLkTimxA9yRHFt8jX2kEM8JvNoO5AOcYA@mail.gmail.com> (raw)
In-Reply-To: <20110609063145.GC15448@one.firstfloor.org>
On Thu, Jun 9, 2011 at 8:31 AM, Andi Kleen <andi@firstfloor.org> wrote:
> On Thu, Jun 09, 2011 at 01:52:24AM -0400, Jeff King wrote:
>> On Thu, Jun 09, 2011 at 06:59:15AM +0200, Andi Kleen wrote:
>>
>> > > - Potential impact to people who do not use Gcc 4.6 with profile feedback
>> > > is not explained away well, except for "Doesn't seem to make any
>> > > difference."
>> >
>> > I merely went by "there are no new warnings" (I assume that's the main
>> > motivation)
>>
>> On your compiler and settings, perhaps. With your patch I get:
>>
>> usage.c: In function ‘die’:
>> usage.c:70:1: error: ‘noreturn’ function does return [-Werror]
>
> Ok. Hmm, all I can say it compiled here.
>
> Ok then we have to remove it. I didn't really like Junio's approach
> to only do it for a single file because that would break with LTO / link
> time optimization which requires declarations to match between
> translation units.
Junio's approach didn't do it for a single file, it disabled the
NORETURN mechanism all together, by having a Makefile-switch.
> BTW 4.6.2 or so will have the problem fixed.
If it's only in 4.6 through 4.6.2, then we probably don't even need a
Makefile-switch for junio's approach at all; just checking the GCC
version should be reliable enough, no?
prev parent reply other threads:[~2011-06-09 21:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-08 21:43 [PATCH 1/2] Remove noreturn function pointers in usage.c Andi Kleen
2011-06-08 21:43 ` [PATCH 2/2] Add profile feedback build to git Andi Kleen
2011-06-09 0:36 ` [PATCH 1/2] Remove noreturn function pointers in usage.c Junio C Hamano
2011-06-09 4:59 ` Andi Kleen
2011-06-09 5:52 ` Jeff King
2011-06-09 6:31 ` Andi Kleen
2011-06-09 21:13 ` Erik Faye-Lund [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTimxA9yRHFt8jX2kEM8JvNoO5AOcYA@mail.gmail.com \
--to=kusmabite@gmail.com \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).