git send-email --body <file> ?

git send-email --body <file> ?

[Jim Cromie]

The perlbug tool is increasingly used by perl community to send patches,
it has options to save report (perlbug.rep by default)

Ive started hacking it to use git send-email when used from inside the git repo
(theyve switched to git :-), and Id like to just use the file it writes.

I tried just passing file in as 1st arg, tool was unhappy:

[jimc@groucho perl]$ git send-email --dry-run  perlbug.rep 0001-*
fatal: perlbug.rep: 61: patch contains a line longer than 998 characters
warning: no patches were sent

I dont want to turn off validation, but if I do, it appears to work,
but my test-send resulted in only the 2 patch files 0001-* arriving
at my inbox, it seems the 1st file (perlbug.rep) was silently rejected.

Indeed, on-screen output shows only 2 sends (below)

--body <file>  seems an ideal solution:
it would read file, and act like --compose if the file were missing
critical stuff, or perhaps just error out.

thanks,
~jimc

[jimc@groucho perl]$ git send-email --to=kidongrok@yahoo.com
--no-validate perlbug.rep 0001-*
perlbug.rep
0001-perlhack.pod-fix-perlbug-invocation.patch
0001-regexp.h-repair-linux-perf-compilation.patch

                                                             Who
should the emails appear to be from? [Jim Cromie
<jim.cromie@gmail.com>]
Emails will be sent from: Jim Cromie <jim.cromie@gmail.com>


Message-ID to be used as In-Reply-To for the first email?
Password:
OK. Log says:
Server: smtp.gmail.com
MAIL FROM:<jim.cromie@gmail.com>
RCPT TO:<kidongrok@yahoo.com>
From: Jim Cromie <jim.cromie@gmail.com>
To: kidongrok@yahoo.com
Subject: [PATCH] b3045a4 perlhack.pod: fix perlbug invocation
Date: Fri, 27 May 2011 13:22:49 -0600
Message-Id: <5.12.3_2182_1306516233@groucho.jimc.earth>
X-Mailer: git-send-email 1.7.4.4
Reply-To: jim.cromie@gmail.com

Result: 250 2.0.0 OK 1306524179 a6sm721905pbo.15

In git 1.7.0, the default has changed to --no-chain-reply-to
Set sendemail.chainreplyto configuration variable to true if
you want to keep --chain-reply-to as your default.
(mbox) Adding cc: Jim Cromie <jim.cromie@gmail.com> from line 'From:
Jim Cromie <jim.cromie@gmail.com>'

From: Jim Cromie <jim.cromie@gmail.com>
To: kidongrok@yahoo.com
Cc: Jim Cromie <jim.cromie@gmail.com>
Subject: [PATCH] perlhack.pod: fix perlbug invocation
Date: Fri, 27 May 2011 13:22:50 -0600
Message-Id: <1306524177-10446-1-git-send-email-jim.cromie@gmail.com>
X-Mailer: git-send-email 1.7.4.4
In-Reply-To: <5.12.3_2182_1306516233@groucho.jimc.earth>
References: <5.12.3_2182_1306516233@groucho.jimc.earth>

    The Cc list above has been expanded by additional
    addresses found in the patch commit message. By default
    send-email prompts before sending whenever this occurs.
    This behavior is controlled by the sendemail.confirm
    configuration setting.

    For additional information, run 'git send-email --help'.
    To retain the current behavior, but squelch this message,
    run 'git config --global sendemail.confirm auto'.


                                                             Send this
email? ([y]es|[n]o|[q]uit|[a]ll): a
OK. Log says:
Server: smtp.gmail.com
MAIL FROM:<jim.cromie@gmail.com>
RCPT TO:<kidongrok@yahoo.com>
RCPT TO:<jim.cromie@gmail.com>
From: Jim Cromie <jim.cromie@gmail.com>
To: kidongrok@yahoo.com
Cc: Jim Cromie <jim.cromie@gmail.com>
Subject: [PATCH] perlhack.pod: fix perlbug invocation
Date: Fri, 27 May 2011 13:22:50 -0600
Message-Id: <1306524177-10446-1-git-send-email-jim.cromie@gmail.com>
X-Mailer: git-send-email 1.7.4.4
In-Reply-To: <5.12.3_2182_1306516233@groucho.jimc.earth>
References: <5.12.3_2182_1306516233@groucho.jimc.earth>

Result: 250 2.0.0 OK 1306524208 a6sm721905pbo.15

(mbox) Adding cc: Jim Cromie <jim.cromie@gmail.com> from line 'From:
Jim Cromie <jim.cromie@gmail.com>'
OK. Log says:
Server: smtp.gmail.com
MAIL FROM:<jim.cromie@gmail.com>
RCPT TO:<kidongrok@yahoo.com>
RCPT TO:<jim.cromie@gmail.com>
From: Jim Cromie <jim.cromie@gmail.com>
To: kidongrok@yahoo.com
Cc: Jim Cromie <jim.cromie@gmail.com>
Subject: [PATCH] regexp.h: repair linux perf compilation
Date: Fri, 27 May 2011 13:22:51 -0600
Message-Id: <1306524177-10446-2-git-send-email-jim.cromie@gmail.com>
X-Mailer: git-send-email 1.7.4.4
In-Reply-To: <5.12.3_2182_1306516233@groucho.jimc.earth>
References: <5.12.3_2182_1306516233@groucho.jimc.earth>

Result: 250 2.0.0 OK 1306524210 a6sm721905pbo.15

Re: git send-email --body <file> ?

[Jim Cromie]

On Fri, May 27, 2011 at 1:56 PM, Jim Cromie <jim.cromie@gmail.com> wrote:
> The perlbug tool is increasingly used by perl community to send patches,
> it has options to save report (perlbug.rep by default)
>
> Ive started hacking it to use git send-email when used from inside the git repo
> (theyve switched to git :-), and Id like to just use the file it writes.
>
> I tried just passing file in as 1st arg, tool was unhappy:
>
> [jimc@groucho perl]$ git send-email --dry-run  perlbug.rep 0001-*
> fatal: perlbug.rep: 61: patch contains a line longer than 998 characters
> warning: no patches were sent
>

Nevermind.

perlbug was doing some odd stuff - it wasnt writing headers to saved file,
so when I went to send it, git-send-email complained.

Ive now hacked perlbug to call git-send-email $rptfile @patchfiles,
without --compose, and things work.

sorry for the noise.