From: "Jérémie NIKAES" <jeremie.nikaes@ensimag.imag.fr>
To: Sverre Rabbelier <srabbelier@gmail.com>
Cc: git@vger.kernel.org,
"Arnaud Lacurie" <arnaud.lacurie@ensimag.imag.fr>,
"Claire Fousse" <claire.fousse@ensimag.imag.fr>,
"David Amouyal" <david.amouyal@ensimag.imag.fr>,
"Matthieu Moy" <matthieu.moy@grenoble-inp.fr>,
"Sylvain Boulmé" <sylvain.boulme@imag.fr>
Subject: Re: [PATCHv3 1/2] Add a remote helper to interact with mediawiki, pull & clone handled
Date: Thu, 9 Jun 2011 16:30:45 +0200 [thread overview]
Message-ID: <BANLkTinduWxp5QR+Ri3REoqVY3hYPc_-rg@mail.gmail.com> (raw)
In-Reply-To: <BANLkTikp6bGwVZqq7XAZ1bKVaMVLJ9XQiw@mail.gmail.com>
2011/6/9 Sverre Rabbelier <srabbelier@gmail.com>:
> Heya,
>
> On Thu, Jun 9, 2011 at 15:15, Jeremie Nikaes
> <jeremie.nikaes@ensimag.imag.fr> wrote:
>> +sub mw_capabilities {
>> + print STDOUT "push\n";
>
>> +sub mw_push {
>> + print STDERR "Push not yet implemented\n";
>> +}
>
> If it's not supported then you shouldn't advertise it above. Is there
> any particular reason you implemented it this way? E.g., did you
> encounter a breakage in remote-helpers if push is not implemented?
Well, if you dont give the capability to push, you get the following message
error: failed to push some refs to 'mediawiki::http://mediawikiurl'
Which is less explicit than 'Push not yet implemented'.
Regards,
--
Jérémie Nikaes
next prev parent reply other threads:[~2011-06-09 14:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-09 13:15 [PATCHv3 1/2] Add a remote helper to interact with mediawiki, pull & clone handled Jeremie Nikaes
2011-06-09 13:16 ` [RFC/PATCH 2/2] Git-remote-mediawiki: Add push support Jeremie Nikaes
2011-06-09 17:15 ` Junio C Hamano
2011-06-09 14:03 ` [PATCHv3 1/2] Add a remote helper to interact with mediawiki, pull & clone handled Sverre Rabbelier
2011-06-09 14:30 ` Jérémie NIKAES [this message]
2011-06-09 14:32 ` Sverre Rabbelier
2011-06-09 22:44 ` Jeff King
2011-06-10 0:21 ` Jeff King
2011-06-10 6:31 ` Arnaud Lacurie
2011-06-10 7:22 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTinduWxp5QR+Ri3REoqVY3hYPc_-rg@mail.gmail.com \
--to=jeremie.nikaes@ensimag.imag.fr \
--cc=arnaud.lacurie@ensimag.imag.fr \
--cc=claire.fousse@ensimag.imag.fr \
--cc=david.amouyal@ensimag.imag.fr \
--cc=git@vger.kernel.org \
--cc=matthieu.moy@grenoble-inp.fr \
--cc=srabbelier@gmail.com \
--cc=sylvain.boulme@imag.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).