From: Linus Torvalds <torvalds@linux-foundation.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Andreas Schwab <schwab@linux-m68k.org>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: Whitespace and ' '
Date: Fri, 27 May 2011 14:14:54 -0700 [thread overview]
Message-ID: <BANLkTinwOr5Yzp_N6BNyNK5Y1FcVtdtbUw@mail.gmail.com> (raw)
In-Reply-To: <7vboyorm4i.fsf@alter.siamese.dyndns.org>
On Fri, May 27, 2011 at 12:15 PM, Junio C Hamano <gitster@pobox.com> wrote:
>
> The "diff" side would look like this. I am tempted to change all the
> "char *line" to "unsigned char *line", before updating "apply", though...
Without actually testing it, it looks reasonable.
I do wonder whether the highlighting might be something that is
independent of whitespace issues. What about mis-formed or
non-printable characters? Right now we depend on "less" doing the
right thing, but I can make "git diff" generate random escape
sequences etc by just putting them in the file, so if I do
GIT_PAGER=cat I can make "git diff" really mess up my terminal if I
wanted to.
Again, I'm not convinced git should really care, but I'm also not
convinced that sbsp is necessarily all about the git whitespace
fixups.
Linus
next prev parent reply other threads:[~2011-05-27 21:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-26 21:12 Whitespace and ' ' Linus Torvalds
2011-05-26 21:57 ` Junio C Hamano
2011-05-26 22:08 ` Linus Torvalds
2011-05-27 16:50 ` Andreas Schwab
2011-05-27 17:01 ` Linus Torvalds
2011-05-27 18:31 ` Junio C Hamano
2011-05-27 19:15 ` Junio C Hamano
2011-05-27 21:14 ` Linus Torvalds [this message]
2011-05-27 22:47 ` Junio C Hamano
2011-05-27 22:48 ` [PATCH 1/3] ws.c: add a helper to format comma separated messages Junio C Hamano
2011-05-27 22:49 ` [PATCH 2/3] War on nbsp: a bit of retreat Junio C Hamano
2011-05-27 22:51 ` [PATCH 3/3] War on nbsp: Add "nbsp" whitespace breakage class Junio C Hamano
2011-05-28 1:31 ` [PATCH 4/3] War on nbsp: teach "git apply" to check and fix nbsp Junio C Hamano
2011-05-30 12:52 ` Whitespace and ' ' Daniel Nyström
2011-05-26 22:21 ` Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTinwOr5Yzp_N6BNyNK5Y1FcVtdtbUw@mail.gmail.com \
--to=torvalds@linux-foundation.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).