git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lars Schneider <larsxschneider@gmail.com>
To: mhagger@alum.mit.edu
Cc: Git List <git@vger.kernel.org>
Subject: Re: [git-sizer] Implications of a large commit object
Date: Wed, 14 Mar 2018 10:40:38 +0100	[thread overview]
Message-ID: <BB908580-36C2-466D-AF05-6BFF7F5E4705@gmail.com> (raw)
In-Reply-To: <CAMy9T_GdYjUm9DqcgrC=NxyTbZk_ep5rvAAK2J=zwhiSMyvaLA@mail.gmail.com>


> On 14 Mar 2018, at 09:33, Michael Haggerty <mhagger@alum.mit.edu> wrote:
> 
> On Wed, Mar 14, 2018 at 9:14 AM, Lars Schneider
> <larsxschneider@gmail.com> wrote:
>> I am using Michael's fantastic Git repo analyzer tool "git-sizer" [*]
>> and it detected a very large commit of 7.33 MiB in my repo (see chart
>> below).
>> 
>> This large commit is expected. I've imported that repo from another
>> version control system but excluded all binary files (e.g. images) and
>> some 3rd party components as their history is not important [**]. I've
>> reintroduced these files in the head commit again. This is where the
>> large commit came from.
>> 
>> This repo is not used in production yet but I wonder if this kind of
>> approach can cause trouble down the line? Are there any relevant
>> implication of a single large commit like this in history?
>> [...]
>> 
>> #######################################################################
>> ## git-sizer output
>> 
>> [...]
>> | Name                         | Value     | Level of concern               |
>> | ---------------------------- | --------- | ------------------------------ |
>> [...]
>> | Biggest objects              |           |                                |
>> | * Commits                    |           |                                |
>> |   * Maximum size         [1] |  7.33 MiB | !!!!!!!!!!!!!!!!!!!!!!!!!!!!!! |
>> [...]
> 
> The "commit size" that is being referred to here is the size of the
> actual commit object; i.e., the author name, parent commits, etc plus
> the log message. So a huge commit probably means that you have a huge
> log message. This has nothing to do with the number or sizes of the
> files added by the commit.
> 
> Maybe your migration tool created a huge commit message, for example
> listing each of the files that was changed.


D'oh! Of course. I was so focused on that commit with the large number of
files that I missed that. Looking at the reference [1] reveals the
problem. Sorry for wasting your time!


> AFAIK this won't cause Git itself any problems, but it's likely to be
> inconvenient. For example, when you type `git log` and 7 million
> characters page by. Or when you use some GUI tool to view your history
> and it performs badly because it wasn't built to handle such enormous
> commit messages.


Thank you,
Lars

  reply	other threads:[~2018-03-14  9:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-14  8:14 [git-sizer] Implications of a large commit object Lars Schneider
2018-03-14  8:33 ` Michael Haggerty
2018-03-14  9:40   ` Lars Schneider [this message]
2018-03-14 14:56   ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BB908580-36C2-466D-AF05-6BFF7F5E4705@gmail.com \
    --to=larsxschneider@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=mhagger@alum.mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).