From: Ben Knoble <ben.knoble@gmail.com>
To: Harald Nordgren <haraldnordgren@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Harald Nordgren via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Josh Steadmon <steadmon@google.com>
Subject: Re: [PATCH] branch: let inherit track a remote-tracking start point
Date: Mon, 19 Oct 2026 10:25:15 -0400 [thread overview]
Message-ID: <BCD8B077-5A67-4A56-9DEB-9B482D580226@gmail.com> (raw)
In-Reply-To: <CAHwyqnVwnMi+DzQDvS6mgUzg-CWACUviVkYv-UiYJT+Yq83QLg@mail.gmail.com>
> Le 17 oct. 2026 à 05:55, Harald Nordgren <haraldnordgren@gmail.com> a écrit :
>
> On Fri, Oct 16, 2026 at 6:55 PM Junio C Hamano <gitster@pobox.com> wrote:
>> Looking at the originating commit d3115660b4 (branch: add flags and
>> config to inherit tracking, 2021-12-20), it only talks about what
>> they want to do when the starting point does track something, and
>> forgets to say what they want when it does not track anything (the
>> author CC'ed in case he retains the memory of the motivation from 5
>> years ago), but if you ask me _now_, not doing anything, i.e., the
>> behaviour the old commit happened to have implemented without
>> explanation does sound like the right thing to do.
>> What we should do if this change of behaviour turns out to be
>> undesirable?
>> Perhaps `inherit` should gain a synonym `inherit-or-ignore` for
>> those who prefer the current behaviour, and we want two extra
>> behaviours, `inherit-or-fail` that complains and dies if the
>> specified starting point does not have anything for the new branch
>> to inherit, and `inherit-or-direct` that uses the fallback
>> definition, or something?
>
> Seems quite overkill for the relatively small problem this is solving.
> But it would be interesting to hear the original author's POV.
Overkill, possibly, but easier to expand in a compatible way over time
(other than piling new modifier --options on top, which makes the CLI confusing IMO).
next prev parent reply other threads:[~2026-10-19 14:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 7:02 [PATCH] branch: let inherit track a remote-tracking start point Harald Nordgren via GitGitGadget
2026-10-16 16:55 ` Junio C Hamano
2026-10-17 9:54 ` Harald Nordgren
2026-10-19 14:25 ` Ben Knoble [this message]
2026-10-19 20:06 ` Junio C Hamano
2026-10-18 9:59 ` Phillip Wood
2026-10-18 15:19 ` Harald Nordgren
2026-10-19 14:26 ` Ben Knoble
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BCD8B077-5A67-4A56-9DEB-9B482D580226@gmail.com \
--to=ben.knoble@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=haraldnordgren@gmail.com \
--cc=steadmon@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox