Re: [PATCH] git-cvsserver runs hooks/post-receive

[Michael Witten <mfwitten@MIT.EDU>]

On 30 Nov 2007, at 7:03:15 AM, Johannes Schindelin wrote:

> Hi,
>
> On Thu, 29 Nov 2007, Michael Witten wrote:
>
>> In any case, I haven't taken a thorough look at how git-cvsserver  
>> works,
>> but it seems to duplicate a lot of git-receive-pack.
>>
>> How about turning git-cvsserver into a true middleman, so that it
>> constructs a 'temporary git working tree' and then does a real git- 
>> push
>> into the final git repository.
>
> That would yield a horrible performance.
>
> Would be opposed, if a regular cvsserver user,

How come?

git-cvsserver it seems already does just that!
The difference is that it puts objects in place
by hand, requiring the code to mirror hook calls
anyway.

I'm simply proposing that the code be reworked,
so that cvs commits actually become git pushes,
so that all future changes to the pushing mechanism
are automatically handled.

It just makes sense as far as design; git-cvsserver
should be an adaptor between the two kinds of repositories,
not an infiltrator.