From: Brian Gernhardt <brian@gernhardtsoftware.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git List <git@vger.kernel.org>, Jakub Narebski <jnareb@gmail.com>
Subject: Re: [PATCH] t/gitweb-lib: Split HTTP response with non-GNU sed
Date: Mon, 23 Nov 2009 13:50:30 -0500 [thread overview]
Message-ID: <BF7341BA-DC27-47C6-B140-2D5A074572E7@gernhardtsoftware.com> (raw)
In-Reply-To: <7vocmtyu3v.fsf@alter.siamese.dyndns.org>
On Nov 23, 2009, at 1:27 PM, Junio C Hamano wrote:
> Brian Gernhardt <brian@gernhardtsoftware.com> writes:
>
>> Recognizing \r in a regex is something GNU sed will do, but other sed
>> implementation's won't. (Found with BSD sed on OS X.) So use a
>> literal carriage return instead.
>
> I'd actually prefer not having to deal with this issue. How about doing
> something like this instead?
Works for me. I just went for the obvious minimal change to make it work. But since we're testing a perl script, we might as well just use perl to deal with it's output.
~~ Brian
next prev parent reply other threads:[~2009-11-23 18:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-23 17:33 [PATCH] t/gitweb-lib: Split HTTP response with non-GNU sed Brian Gernhardt
2009-11-23 18:27 ` Junio C Hamano
2009-11-23 18:50 ` Brian Gernhardt [this message]
2009-11-24 16:59 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BF7341BA-DC27-47C6-B140-2D5A074572E7@gernhardtsoftware.com \
--to=brian@gernhardtsoftware.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).