From: "Philip Oakley" <philipoakley@iee.org>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: "GitList" <git@vger.kernel.org>
Subject: Re: [PATCH v1 2/3] doc: rebase: fixup! can take an object name
Date: Mon, 15 Aug 2016 00:00:15 +0100 [thread overview]
Message-ID: <BF74616BD9694719A6C0D6E75ACD9CE6@PhilipOakley> (raw)
In-Reply-To: xmqqziofj90b.fsf@gitster.mtv.corp.google.com
From: "Junio C Hamano" <gitster@pobox.com>
> Philip Oakley <philipoakley@iee.org> writes:
>
>> Since 68d5d03 (rebase: teach --autosquash to match on sha1 in addition
>> to message, 2010-11-04) the commit subject can refer directly to the
>> destination object hash as a single word.)...
>
> That's not an object hash but an object name (see glossary); you got
> it right in the actual patch text, though ;-).
As noted in 1/3, the glossary also needs a fix (for those who read it) to
make sure the name-value confusion is distinguished, with the potential
'object names' (colloquial) being via (git) 'revisions', while the
cannonical object name is the (oid) sha1 hash. Somehow folk need pointing at
the (broad) ways of spelling commit names rather than just the narrow sha. A
bit of a finger and the moon problem.
>
>> diff --git a/Documentation/git-rebase.txt b/Documentation/git-rebase.txt
>> index 0387b40..66b789a 100644
>> --- a/Documentation/git-rebase.txt
>> +++ b/Documentation/git-rebase.txt
>> @@ -421,7 +421,8 @@ without an explicit `--interactive`.
>> --no-autosquash::
>> When the commit log message begins with "squash! ..." (or
>> "fixup! ..."), and there is a commit whose title begins with
>> - the same ..., automatically modify the todo list of rebase -i
>> + the same "..." message, or a commit object name (standalone),
>> + automatically modify the todo list of rebase -i
>
> What's "(standalone)"? I can understand the updated text and agree
> that it is better than the original without that part, though.
the 'standalone' is that it must be a single (standalone) word on the
subject line immediately after the "fixup! "(s).
communicationg that one cannot have any extra textual notes after that word
was the issue that 'standalone' tried to address.
--
Philip
next prev parent reply other threads:[~2016-08-14 23:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-14 21:46 [PATCH v1 0/3] fixup fixup documenation Philip Oakley
2016-08-14 21:46 ` [PATCH v1 1/3] doc: commit: --fixup/--squash can take a commit revision Philip Oakley
2016-08-14 22:09 ` Junio C Hamano
2016-08-14 22:45 ` Philip Oakley
2016-08-14 22:55 ` Junio C Hamano
2016-08-14 23:29 ` Philip Oakley
2016-08-16 22:11 ` Philip Oakley
2016-08-14 21:46 ` [PATCH v1 2/3] doc: rebase: fixup! can take an object name Philip Oakley
2016-08-14 22:11 ` Junio C Hamano
2016-08-14 23:00 ` Philip Oakley [this message]
2016-08-14 23:02 ` Junio C Hamano
2016-08-14 23:30 ` Philip Oakley
2016-08-14 21:46 ` [PATCH v1 3/3] doc: rebase: clarify fixup! fixup! constraint Philip Oakley
2016-08-14 22:20 ` Junio C Hamano
2016-08-14 23:23 ` Philip Oakley
2016-08-15 15:42 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BF74616BD9694719A6C0D6E75ACD9CE6@PhilipOakley \
--to=philipoakley@iee.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox