RE: Version 1.8.1 does not compile on Cygwin 1.7.14

["Jason Pyeron" <jpyeron@pdinc.us>]

> -----Original Message-----
> From: Junio C Hamano
> Sent: Sunday, January 06, 2013 16:36
> 
> Thanks; so perhaps you can give me an OK to forge your S-o-b 
> to the following?

I am personally fine with it, because cygwin is used by developers not
production systems and I expect my developers to upgrade their environment for
security fixes, etc.
If I ever had a situation where I am using git, in production, on cygwin, where
I could not upgrade I would effort to make a compile test based patch to the
make file to accommodate the issue.

> 
> -- >8 --
> From: Mark Levedahl <mlevedahl@gmail.com>
> Date: Sun, 6 Jan 2013 11:56:33 -0800
> Subject: [PATCH] Makefile: add comment on CYGWIN_V15_WIN32API
> 
> There is no documented, reliable, and future-proof method to 
> determine the installed w32api version on Cygwin. There are 
> many things that can be done that will work frequently, 
> except when they won't.
> 
> The only sane thing is to follow the guidance of the Cygwin
> developers: the only supported configuration is that which 
> the current setup.exe produces, and in the case of problems, 
> if the installation is not up to date then updating is the 
> first required action.
> 
> Signed-off-by: Mark Levedahl <mlevedahl@gmail.com>
> ---
>  Makefile | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Makefile b/Makefile
> index 4d47af5..52e298a 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -273,6 +273,10 @@ all::
>  #
>  # Define NO_REGEX if you have no or inferior regex support 
> in your C library.
>  #
> +# Define CYGWIN_V15_WIN32API if you are using Cygwin v1.7.x 
> but are not 
> +# using the current w32api packages. The recommended 
> approach, however, 
> +# is to update your installation if compilation errors occur.
> +#
>  # Define HAVE_DEV_TTY if your system can open /dev/tty to 
> interact with the  # user.
>  #
> --
> 1.8.1.302.g0f4eaa7

--
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
-                                                               -
- Jason Pyeron                      PD Inc. http://www.pdinc.us -
- Principal Consultant              10 West 24th Street #100    -
- +1 (443) 269-1555 x333            Baltimore, Maryland 21218   -
-                                                               -
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
This message is copyright PD Inc, subject to license 20080407P00.