git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ben Knoble <ben.knoble@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Aditya Garg <gargaditya08@live.com>,
	git@vger.kernel.org, Julian Swagemakers <julian@swagemakers.org>,
	Eric Sunshine <sunshine@sunshineco.com>,
	Zi Yao <ziyao@disroot.org>,
	Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>,
	sandals@crustytoothpaste.net,
	Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH v5 2/4] docs: improve formatting in git-send-email documentation
Date: Fri, 30 May 2025 10:48:28 -0400	[thread overview]
Message-ID: <C1E8439B-7666-472F-9C23-C558BA9ED53E@gmail.com> (raw)
In-Reply-To: <877c1yb53w.fsf@gitster.g>


> Le 30 mai 2025 à 09:28, Junio C Hamano <gitster@pobox.com> a écrit :
> 
> Aditya Garg <gargaditya08@live.com> writes:
> 
>>>> -When `--compose` is used, git send-email will use the From, To, Cc, Bcc,
>>>> -Subject, Reply-To, and In-Reply-To headers specified in the message. If
>>>> -the body of the message (what you type after the headers and a blank
>>>> -line) only contains blank (or Git: prefixed) lines, the summary won't be
>>>> +When `--compose` is used, `git send-email` will use the 'From', 'To', 'Cc',
>>>> +'Bcc', 'Subject', 'Reply-To', and 'In-Reply-To' headers specified in the
>>>> +message. If the body of the message (what you type after the headers and a
>>>> +blank line) only contains blank (or Git: prefixed) lines, the summary won't be
>>> 
>>> Shouldn't 'Git:' in "or Git: prefixed" be marked-up somehow as well?
>>> 
>>> As these mail header names are all literal parts, shouldn't ehy be
>>> marked up like `To`, `Cc`, etc.?
>> 
>> I think its ok to let these remain in '', and deviate from the rules a bit.
>> If backticks are used, it will be a mess when rendered on the website.
> 
> I do not think I agree; bending the rule only because the density of
> literals in a single paragraph is too heavy does not sound like a
> good application of a rule---it is hard to justify such an
> exception.

To go a bit further, rendered HTML is also not the only output format, though I don’t think the markup here affects manual pages substantially? So using « the website » (which? presumably git-scm.com) as justification prioritizes the look of one output format over other concerns, no?

For plaintext viewing, consistency is probably helpful.  

> 
>>>> -    by 'c_rehash', or a single file containing one or more PEM format
>>>> -    certificates concatenated together: see verify(1) -CAfile and
>>>> -    -CApath for more information on these). Set it to an empty string
>>>> +    by `c_rehash`, or a single file containing one or more PEM format
>>>> +    certificates concatenated together). Set it to an empty string
>>> 
>>> What is this change about?  grammatical errors?  non existent links?
>>> cpan links?  It does not look any of these.
>> 
>> Non existing links. Checkout the website.
> 
> But I do not see any link in ...
> 
>>>> -    by 'c_rehash', or a single file containing one or more PEM format
>>>> -    certificates concatenated together: see verify(1) -CAfile and
>>>> -    -CApath for more information on these). Set it to an empty string
> 
> ... the text that was removed.  The reference to verify(1) is a
> command in the OpenSSL suite, right?
> 

  parent reply	other threads:[~2025-05-30 14:48 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-13 18:28 [PATCH] docs: add instructions to use Yahoo with send-mail Aditya Garg
2025-05-13 18:33 ` Aditya Garg
2025-05-13 18:42   ` Junio C Hamano
2025-05-13 18:51     ` Aditya Garg
2025-05-13 19:36       ` Aditya Garg
2025-05-14 12:58 ` Junio C Hamano
2025-05-14 13:05   ` Aditya Garg
2025-05-15 10:29 ` [PATCH v2 0/2] docs: update email credential helpers Aditya Garg
2025-05-15 10:29   ` [PATCH v2 1/2] docs: add credential helper for yahoo and link Google's sendgmail tool Aditya Garg
2025-05-15 10:29   ` [PATCH v2 2/2] docs: remove credential helper links for emails from gitcredentials Aditya Garg
2025-05-18  7:34   ` [PATCH v3 0/3] docs: update email credential helpers and improve formatting Aditya Garg
2025-05-18  7:35     ` [PATCH v3 1/3] docs: add credential helper for yahoo and link Google's sendgmail tool Aditya Garg
2025-05-18  7:36     ` [PATCH v3 2/3] docs: improve formatting in git-send-email documentation Aditya Garg
2025-05-18  7:36     ` [PATCH v3 3/3] docs: remove credential helper links for emails from gitcredentials Aditya Garg
2025-05-19 12:51 ` [PATCH v4 0/3] docs: update email credential helpers and improve formatting Aditya Garg
2025-05-19 12:52   ` [PATCH v4 1/3] docs: add credential helper for yahoo and link Google's sendgmail tool Aditya Garg
2025-05-19 12:52   ` [PATCH v4 2/3] docs: improve formatting in git-send-email documentation Aditya Garg
2025-05-19 12:53   ` [PATCH v4 3/3] docs: remove credential helper links for emails from gitcredentials Aditya Garg
2025-05-19 18:26   ` [PATCH v4 0/3] docs: update email credential helpers and improve formatting Junio C Hamano
2025-05-19 18:29     ` Aditya Garg
2025-05-28  7:05 ` [PATCH v5 0/4] " Aditya Garg
2025-05-28  7:05   ` [PATCH v5 1/4] docs: add credential helper for yahoo and link Google's sendgmail tool Aditya Garg
2025-05-28  7:05   ` [PATCH v5 2/4] docs: improve formatting in git-send-email documentation Aditya Garg
2025-05-29 18:15     ` Junio C Hamano
2025-05-29 19:04       ` Aditya Garg
2025-05-30 13:28         ` Junio C Hamano
2025-05-30 13:32           ` Aditya Garg
2025-05-30 17:15             ` Junio C Hamano
2025-05-30 17:19               ` Aditya Garg
2025-05-30 21:55                 ` Junio C Hamano
2025-05-30 14:48           ` Ben Knoble [this message]
2025-05-30 14:51             ` Aditya Garg
2025-05-28  7:05   ` [PATCH v5 3/4] docs: remove credential helper links for emails from gitcredentials Aditya Garg
2025-05-28  7:05   ` [PATCH v5 4/4] docs: make the purpose of using app password for Gmail more clear in send-email Aditya Garg
2025-05-29 18:50     ` Junio C Hamano
2025-05-29 19:06       ` Aditya Garg
2025-05-28  7:23   ` [PATCH v5 0/4] docs: update email credential helpers and improve formatting Eric Sunshine
2025-05-28  9:36     ` Aditya Garg
2025-05-28  9:42       ` Aditya Garg
2025-05-28 10:05         ` Aditya Garg
2025-05-28 10:10       ` Aditya Garg
2025-05-30 11:37 ` [PATCH v6 " Aditya Garg
2025-05-30 11:37   ` [PATCH v6 1/4] docs: add credential helper for yahoo and link Google's sendgmail tool Aditya Garg
2025-05-30 11:37   ` [PATCH v6 2/4] docs: improve formatting in git-send-email documentation Aditya Garg
2025-05-30 11:37   ` [PATCH v6 3/4] docs: remove credential helper links for emails from gitcredentials Aditya Garg
2025-05-30 11:37   ` [PATCH v6 4/4] docs: make the purpose of using app password for Gmail more clear in send-email Aditya Garg
2025-05-30 15:50 ` [PATCH v7 0/4] docs: add credential helper for yahoo and link Google's sendgmail tool Aditya Garg
2025-05-30 15:50   ` [PATCH v7 1/4] " Aditya Garg
2025-05-30 15:50   ` [PATCH v7 2/4] docs: improve formatting in git-send-email documentation Aditya Garg
2025-05-30 15:50   ` [PATCH v7 3/4] docs: remove credential helper links for emails from gitcredentials Aditya Garg
2025-05-30 15:50   ` [PATCH v7 4/4] docs: make the purpose of using app password for Gmail more clear in send-email Aditya Garg
2025-05-30 17:28     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C1E8439B-7666-472F-9C23-C558BA9ED53E@gmail.com \
    --to=ben.knoble@gmail.com \
    --cc=gargaditya08@live.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=johannes.schindelin@gmx.de \
    --cc=julian@swagemakers.org \
    --cc=kristofferhaugsbakk@fastmail.com \
    --cc=sandals@crustytoothpaste.net \
    --cc=sunshine@sunshineco.com \
    --cc=ziyao@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).