From: Lars Schneider <larsxschneider@gmail.com>
To: Andrew Oakley <aoakley@roku.com>
Cc: git@vger.kernel.org, luke@diamand.org
Subject: Re: [PATCH 1/1] git-p4: correct hasBranchPrefix verbose output
Date: Tue, 21 Jun 2016 20:05:39 +0200 [thread overview]
Message-ID: <C471957C-3FEE-4CEB-8940-624F73784355@gmail.com> (raw)
In-Reply-To: <1466517222-12600-1-git-send-email-aoakley@roku.com>
> On 21 Jun 2016, at 15:53, Andrew Oakley <aoakley@roku.com> wrote:
>
> The logic here was inverted, you got a message saying the file is
> ignored for each file that is not ignored.
> ---
> git-p4.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/git-p4.py b/git-p4.py
> index b6593cf..b123aa2 100755
> --- a/git-p4.py
> +++ b/git-p4.py
> @@ -2674,7 +2674,7 @@ class P4Sync(Command, P4UserMap):
> return True
> hasPrefix = [p for p in self.branchPrefixes
> if p4PathStartsWith(path, p)]
> - if hasPrefix and self.verbose:
> + if not hasPrefix and self.verbose:
Thanks Andrew! Your fix is correct.
- Lars
> print('Ignoring file outside of prefix: {0}'.format(path))
> return hasPrefix
>
> --
> 2.7.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-06-21 18:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 13:53 [PATCH 1/1] git-p4: correct hasBranchPrefix verbose output Andrew Oakley
2016-06-21 18:05 ` Lars Schneider [this message]
2016-06-21 18:16 ` Junio C Hamano
2016-06-22 9:24 ` Andrew Oakley
2016-06-22 9:26 ` Andrew Oakley
2016-06-22 18:38 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C471957C-3FEE-4CEB-8940-624F73784355@gmail.com \
--to=larsxschneider@gmail.com \
--cc=aoakley@roku.com \
--cc=git@vger.kernel.org \
--cc=luke@diamand.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).