git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: [RFD] use approxidate for "git commit --date=xyz"?
Date: Wed, 30 Apr 2014 14:09:10 -0700	[thread overview]
Message-ID: <CA+55aFx=LizEyS6hq=av_qwRZuu_q3xPSXO-Jr4CAfXqaAuUtA@mail.gmail.com> (raw)

I just got a comment saying that

    git commit --amend --date=now

doesn't work. I replied that you can use

   --date="$(date)"

but I do wonder if we should accept the approxidate format - we do in
other equivalent places. Hmm?

The code uses fmt_ident(), which uses parse_date(), which in turn uses
parse_date_basic(). Maybe parse_date() could use
"approxidate_careful()" instead of "parse_date_basic()"?

            Linus

             reply	other threads:[~2014-04-30 21:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-30 21:09 Linus Torvalds [this message]
2014-04-30 21:34 ` [RFD] use approxidate for "git commit --date=xyz"? Junio C Hamano
2014-05-01 22:06   ` Jeff King
2014-05-02  1:03     ` [PATCH 0/4] approxidate for "git commit --date=foo" Jeff King
2014-05-02  1:06       ` [PATCH 1/4] commit: use split_ident_line to compare author/committer Jeff King
2014-05-02  1:07       ` [PATCH 2/4] pretty: make show_ident_date public Jeff King
2014-05-02  1:10       ` [PATCH 3/4] commit: print "Date" line when the user has set date Jeff King
2014-05-02  1:12       ` [PATCH 4/4] commit: accept more date formats for "--date" Jeff King
2014-05-07  7:22   ` [RFD] use approxidate for "git commit --date=xyz"? Peter Krefting

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+55aFx=LizEyS6hq=av_qwRZuu_q3xPSXO-Jr4CAfXqaAuUtA@mail.gmail.com' \
    --to=torvalds@linux-foundation.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).