From: Linus Torvalds <torvalds@linux-foundation.org>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Michael Cree <mcree@orcon.net.nz>,
git@vger.kernel.org, Nicolas Pitre <nico@fluxnic.net>
Subject: Re: [PATCH maint-1.6.5 v2] block-sha1: avoid pointer conversion that violates alignment constraints
Date: Sat, 14 Jul 2012 13:56:17 -0700 [thread overview]
Message-ID: <CA+55aFxHAPJi9cKVy6Mi7gunHT3PPLEQUwJBFQ4ftO2szc_dow@mail.gmail.com> (raw)
In-Reply-To: <20120714205049.GA28502@burratino>
Looks good to me. I'd suggest doing the macro argument expansion in
#define SHA_SRC(t) get_be32((unsigned char *) block + t*4)
with parenthesis around 't', but that's a fairly independent thing.
The old code didn't do that either.
Linus
next prev parent reply other threads:[~2012-07-14 20:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120713233957.6928.87541.reportbug@electro.phys.waikato.ac.nz>
[not found] ` <20120714002950.GA3159@burratino>
[not found] ` <5000CBCA.8020607@orcon.net.nz>
[not found] ` <20120714021856.GA3062@burratino>
[not found] ` <50010B84.5030606@orcon.net.nz>
2012-07-14 7:59 ` [PATCH maint-1.6.5] block-sha1: avoid unaligned accesses on some big-endian systems Jonathan Nieder
2012-07-14 19:11 ` Linus Torvalds
2012-07-14 19:50 ` Jonathan Nieder
2012-07-14 19:55 ` Linus Torvalds
2012-07-14 20:50 ` [PATCH maint-1.6.5 v2] block-sha1: avoid pointer conversion that violates alignment constraints Jonathan Nieder
2012-07-14 20:56 ` Linus Torvalds [this message]
2012-07-14 21:57 ` [PATCH] block-sha1: put macro arguments in parentheses Jonathan Nieder
2012-07-15 20:58 ` [PATCH maint-1.6.5 v2] block-sha1: avoid pointer conversion that violates alignment constraints Michael Cree
2012-07-15 21:27 ` Jonathan Nieder
2012-07-16 9:53 ` Michael Cree
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+55aFxHAPJi9cKVy6Mi7gunHT3PPLEQUwJBFQ4ftO2szc_dow@mail.gmail.com \
--to=torvalds@linux-foundation.org \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=mcree@orcon.net.nz \
--cc=nico@fluxnic.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).