From: Linus Torvalds <torvalds@linux-foundation.org>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Git Mailing List <git@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] .gitattributes: Enable cpp diff parsing for .[ch] files
Date: Fri, 26 Aug 2011 13:27:43 -0700 [thread overview]
Message-ID: <CA+55aFxNXK-AJdrHBBycM5W632qUBi4E=jangcdRoefQiHzbug@mail.gmail.com> (raw)
In-Reply-To: <4E56CE8F.8080501@panasas.com>
On Thu, Aug 25, 2011 at 3:37 PM, Boaz Harrosh <bharrosh@panasas.com> wrote:
>
> Add a .gitattributes file to the Linux tree to enable cpp parsing
> of the source files.
Hmm. I'm not entirely conviced. If people really think that the hunk
description matters that much, maybe we should just instead improve on
the automatic diff detection, and extend it from just binary-vs-text,
to also do the common hunk-headers.
After all, not having a diff pattern already *does* mean "automatic",
so it would be just a rather trivial extension to that.
Junio?
Linus
next prev parent reply other threads:[~2011-08-26 20:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-25 22:37 [PATCH] .gitattributes: Enable cpp diff parsing for .[ch] files Boaz Harrosh
2011-08-26 20:27 ` Linus Torvalds [this message]
2011-08-26 20:54 ` Junio C Hamano
2011-08-26 20:59 ` Linus Torvalds
2011-08-26 20:55 ` Boaz Harrosh
2011-08-29 13:32 ` Peter Zijlstra
2011-08-29 20:57 ` Boaz Harrosh
2011-08-29 21:30 ` Peter Zijlstra
2011-08-29 22:02 ` Linus Torvalds
2011-08-29 22:43 ` Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+55aFxNXK-AJdrHBBycM5W632qUBi4E=jangcdRoefQiHzbug@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=bharrosh@panasas.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).