From: Linus Torvalds <torvalds@linux-foundation.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: USE_SHA1DC is broken in pu
Date: Thu, 16 Mar 2017 12:22:00 -0700 [thread overview]
Message-ID: <CA+55aFzJ3NFVoN6K9__nM_LWYfegxGo_YxB0OudTNBCG+qq+3Q@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 213 bytes --]
I think there's a semantic merge error and it clashes with
f18f816cb158 ("hash.h: move SHA-1 implementation selection into a
header file").
Suggested possible merge resolution attached.
Linus
[-- Attachment #2: patch.diff --]
[-- Type: text/plain, Size: 739 bytes --]
Makefile | 2 +-
hash.h | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 9d1d958bd..186ce17f2 100644
--- a/Makefile
+++ b/Makefile
@@ -1388,9 +1388,9 @@ ifdef APPLE_COMMON_CRYPTO
endif
ifdef USE_SHA1DC
- SHA1_HEADER = "sha1dc/sha1.h"
LIB_OBJS += sha1dc/sha1.o
LIB_OBJS += sha1dc/ubc_check.o
+ BASIC_CFLAGS += -DSHA1DC
else
ifdef BLK_SHA1
LIB_OBJS += block-sha1/sha1.o
diff --git a/hash.h b/hash.h
index f0d9ddd0c..b7f4f1fd8 100644
--- a/hash.h
+++ b/hash.h
@@ -7,6 +7,8 @@
#include <CommonCrypto/CommonDigest.h>
#elif defined(SHA1_OPENSSL)
#include <openssl/sha.h>
+#elif defined(SHA1DC)
+#include "sha1dc/sha1.h"
#else /* SHA1_BLK */
#include "block-sha1/sha1.h"
#endif
next reply other threads:[~2017-03-16 19:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-16 19:22 Linus Torvalds [this message]
2017-03-16 19:41 ` USE_SHA1DC is broken in pu Jeff King
2017-03-16 19:44 ` Linus Torvalds
2017-03-16 19:46 ` Junio C Hamano
2017-03-16 19:51 ` Linus Torvalds
2017-03-16 20:26 ` Linus Torvalds
2017-03-16 19:41 ` Junio C Hamano
2017-03-17 3:18 ` Lars Schneider
2017-03-17 3:32 ` Lars Schneider
2017-03-21 20:09 ` Johannes Schindelin
2017-03-21 20:16 ` Junio C Hamano
2017-03-22 14:32 ` Johannes Schindelin
2017-03-22 22:02 ` Jonathan Nieder
2017-03-23 16:43 ` Johannes Schindelin
2017-03-23 17:16 ` Linus Torvalds
2017-03-23 17:47 ` Jeff King
2017-03-23 19:02 ` Junio C Hamano
2017-03-23 22:22 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+55aFzJ3NFVoN6K9__nM_LWYfegxGo_YxB0OudTNBCG+qq+3Q@mail.gmail.com \
--to=torvalds@linux-foundation.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).