From: Skrab Sah <skrab.sah@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: skrab-sah via GitGitGadget <gitgitgadget@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] abspath.h is created.
Date: Wed, 28 Sep 2022 13:02:22 +0530 [thread overview]
Message-ID: <CA+J78MXbXG4M1w50EAM8t0VkYP_saCt9O90jFKad3+cB+RCZ-Q@mail.gmail.com> (raw)
In-Reply-To: <xmqq8rm41gbp.fsf@gitster.g>
What is wrong here and what should i do to make it correct.
On Wed, 28 Sept 2022 at 06:11, Junio C Hamano <gitster@pobox.com> wrote:
>
> "skrab-sah via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
> > diff --git a/abspath.h b/abspath.h
> > new file mode 100644
> > index 00000000000..edebc3a53ba
> > --- /dev/null
> > +++ b/abspath.h
> > @@ -0,0 +1,9 @@
> > +/* This file was automatically generated. Do not edit! */
>
> No thanks.
>
> I suspect this change is taking us in a wrong direction. People
> grep for function and struct declarations in <*.h> files and expect
> to find the associated comments.
next prev parent reply other threads:[~2022-09-28 7:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 16:08 [PATCH] abspath.h is created skrab-sah via GitGitGadget
2022-09-28 0:40 ` Junio C Hamano
2022-09-28 7:32 ` Skrab Sah [this message]
2022-09-28 15:39 ` Taylor Blau
2022-09-28 17:58 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+J78MXbXG4M1w50EAM8t0VkYP_saCt9O90jFKad3+cB+RCZ-Q@mail.gmail.com \
--to=skrab.sah@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).