From: Erik Cervin Edin <erik@cervined.in>
To: Philip Oakley <philipoakley@iee.email>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>,
"Ignacio Taranto" <ignacio.taranto@eclypsium.com>,
git@vger.kernel.org
Subject: Re: About git reporting missing newline for symlinks
Date: Fri, 14 Oct 2022 00:01:02 +0200 [thread overview]
Message-ID: <CA+JQ7M_HJf_o=u4DOjdGet5D88kWEDJ+AbwfAWVnx487VSVu=Q@mail.gmail.com> (raw)
In-Reply-To: <aead3926-d87b-5fcd-4984-bb690f3fbf4e@iee.email>
On Thu, Oct 13, 2022 at 10:55 PM Philip Oakley <philipoakley@iee.email> wrote:
>
> Pondering on why it is thought of as a warning to be treated as an
> error, maybe the message implies something is missing via the negative
> "No" assertion, rather than simply being informative [1].
Very likely. I imagine most users use diff to view the
changes they made without knowledge of the use of diffs in git-apply.
Without that background it's more likely to be interpreted as an
opinionated comment as opposed to being informative.
> Perhaps swapping out the "No" and instead using something like "\
> Without a newline at end of file" would better convey that it's just
> information about the file's format, and in no way a real problem. Just
> a thought.
That's probably less likely to be read as a warning
next prev parent reply other threads:[~2022-10-13 22:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 21:17 About git reporting missing newline for symlinks Ignacio Taranto
2022-10-12 21:31 ` Junio C Hamano
2022-10-12 21:42 ` Ignacio Taranto
2022-10-13 13:11 ` Ævar Arnfjörð Bjarmason
2022-10-13 16:02 ` Junio C Hamano
2022-10-13 16:57 ` Ævar Arnfjörð Bjarmason
2022-10-13 18:50 ` Junio C Hamano
2022-10-13 19:33 ` Ævar Arnfjörð Bjarmason
2022-10-13 20:06 ` Junio C Hamano
2022-10-13 20:34 ` Philip Oakley
2022-10-13 22:01 ` Erik Cervin Edin [this message]
2022-10-12 21:32 ` brian m. carlson
2022-10-12 21:34 ` Junio C Hamano
2022-10-12 21:42 ` brian m. carlson
2022-10-13 2:17 ` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+JQ7M_HJf_o=u4DOjdGet5D88kWEDJ+AbwfAWVnx487VSVu=Q@mail.gmail.com' \
--to=erik@cervined.in \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ignacio.taranto@eclypsium.com \
--cc=philipoakley@iee.email \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).