From: JAYATHEERTH K <jayatheerthkulkarni2005@gmail.com>
To: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/1] add: fix pathspec handling when literal filenames match wildcard
Date: Sat, 12 Apr 2025 23:04:40 +0530 [thread overview]
Message-ID: <CA+rGoLdDVYKUz02dhgPy50nhG-K-cjyLUySFtunGL1+f=AD7wg@mail.gmail.com> (raw)
In-Reply-To: <9EB38EEC-97EA-4F8D-BCC6-883771203755@gmail.com>
On Sat, Apr 12, 2025 at 9:15 PM Lucas Seiki Oshiro
<lucasseikioshiro@gmail.com> wrote:
>
> Hi!
Hey Lucas!
>
> The original bug repot included some simple steps to reproduce
> the bug. Since it is a corner case that wasn't covered by our
> current test suite, it would be nice if you created a new
> test case covering that.
>
Yeah!! I was testing them with options like f** and f\*\* for specific
file additions for commits
I have framed a test frame in t-3706 which is the add and pathspec
coverage as far as I can see.
> PS: Since this is a single patch, you could sent this without
> a cover letter, putting your comments after the scissors mark
> (---).
Ahh I do that because if I receive feedback it forms like a good
summary in the beginning.
But sure, I think the *scissors mark* method sounds good too!!
Will send the patch inline to this email
I think you've worked with Tests in your microproject
Drop some feedback. Those will be very helpful!!
Thank you,
-Jayatheerth
prev parent reply other threads:[~2025-04-12 17:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-12 9:46 [PATCH 0/1] add: fix pathspec handling when literal filenames match wildcard K Jayatheerth
2025-04-12 9:46 ` [PATCH 1/1] add: fix handling literal filenames and wildcards K Jayatheerth
2025-04-12 17:40 ` [PATCH] t3706: Add test for wildcard vs literal pathspec K Jayatheerth
2025-04-14 16:51 ` Lucas Seiki Oshiro
2025-04-14 17:08 ` JAYATHEERTH K
2025-04-14 21:42 ` Junio C Hamano
2025-04-15 22:32 ` brian m. carlson
2025-04-16 1:56 ` JAYATHEERTH K
2025-04-16 13:11 ` Junio C Hamano
2025-04-16 14:49 ` JAYATHEERTH K
2025-04-16 15:49 ` Lucas Seiki Oshiro
2025-04-16 16:00 ` Junio C Hamano
2025-04-19 4:59 ` JAYATHEERTH K
2025-04-19 17:43 ` Lucas Seiki Oshiro
2025-04-22 11:57 ` JAYATHEERTH K
2025-04-16 16:40 ` JAYATHEERTH K
2025-04-16 16:43 ` JAYATHEERTH K
2025-04-12 15:45 ` [PATCH 0/1] add: fix pathspec handling when literal filenames match wildcard Lucas Seiki Oshiro
2025-04-12 17:34 ` JAYATHEERTH K [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+rGoLdDVYKUz02dhgPy50nhG-K-cjyLUySFtunGL1+f=AD7wg@mail.gmail.com' \
--to=jayatheerthkulkarni2005@gmail.com \
--cc=git@vger.kernel.org \
--cc=lucasseikioshiro@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).