git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Brandon Casey <drafnel@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Heiko Becker <heirecka@exherbo.org>,
	"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH] gnome-keyring: Don't hard-code pkg-config executable
Date: Thu, 16 Jun 2016 11:56:13 -0700	[thread overview]
Message-ID: <CA+sFfMf_NQSqrz0FRPyTcD7zgfe7VbeHUoFccVCJzW3Bon3j5g@mail.gmail.com> (raw)
In-Reply-To: <20160616095001.GI15851@sigill.intra.peff.net>

On Thu, Jun 16, 2016 at 2:50 AM, Jeff King <peff@peff.net> wrote:
> On Tue, Jun 14, 2016 at 01:27:05PM +0200, Heiko Becker wrote:
>
>> Helpful if your pkg-config executable has a prefix based on the
>> architecture, for example.
>>
>> Signed-off-by: Heiko Becker <heirecka@exherbo.org>
>
> Sounds like a reasonable thing to want to do...

ditto.

> ...and the implementation looks obviously correct.

ditto.

> Thanks.

ditto.

See I'm still alive, really!

-Brandon

      reply	other threads:[~2016-06-16 18:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-14 11:27 [PATCH] gnome-keyring: Don't hard-code pkg-config executable Heiko Becker
2016-06-16  9:50 ` Jeff King
2016-06-16 18:56   ` Brandon Casey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+sFfMf_NQSqrz0FRPyTcD7zgfe7VbeHUoFccVCJzW3Bon3j5g@mail.gmail.com \
    --to=drafnel@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=heirecka@exherbo.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).