git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ben Nason <bnason@netflix.com>
To: git@vger.kernel.org
Subject: [BUG?] Issue with merging from another branch after replacing subdirectory with submodule
Date: Wed, 5 Apr 2017 23:10:02 -0700	[thread overview]
Message-ID: <CAA-fqg2EwfMQ-KoAMHDFca1c7jpQgihhqsLejEK3Zs8O1D4DLg@mail.gmail.com> (raw)

Hi,

In git if you replace a subdirectory with a submodule in one branch,
every successive merge from another branch without that change will
cause a conflict. To reproduce this please see below (DOS batch file).

Is this expected behavior?

Thanks,
Benbuck

:: prep simple repo with subdir
git init repo
pushd repo
echo foo > foo.txt
git add --all
git commit -m "foo"
mkdir sub
echo bar > sub\bar.txt
git add --all
git commit -m "bar"
popd

:: prep simple submodule
git init submod
pushd submod
echo baz2 > baz.txt
git add --all
git commit -m "baz2"
popd

:: in a new branch: delete subdir, replace with submodule
pushd repo
git checkout -b resub
git rm -rf sub
git commit -m "delete subdir"
git submodule add ../submod sub
git submodule update --init
git commit -m "add submod"

:: in old branch: make an unrelated change
git checkout master
git clean -fd
git rs --hard master
echo foo2 > foo.txt
git commit --all -m "foo2"

:: switch back to new branch
git checkout resub
git rs --hard resub
git submodule update --init
pushd sub
git reset --hard master
popd

:: all is good so far, now merge
git merge master
git status
@echo !!!!!! note the above merge conflict !!!!!!
pause
:: resolve the conflict to keep the submodule
git reset sub
git commit --no-edit


:: make another change to old branch
git checkout master
git clean -fd
git rs --hard master
echo foo3 > foo.txt
git commit --all -m "foo3"
git checkout resub
git rs --hard resub
git submodule update --init
pushd sub
git reset --hard master
popd

:: merge again
git merge master
git status
@echo !!!!!! note that the conflict happens on every single merge !!!!!!
pause

popd

             reply	other threads:[~2017-04-06  6:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-06  6:10 Ben Nason [this message]
2017-04-06 23:05 ` [BUG?] Issue with merging from another branch after replacing subdirectory with submodule Stefan Beller
2017-04-07 15:25   ` Ben Nason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAA-fqg2EwfMQ-KoAMHDFca1c7jpQgihhqsLejEK3Zs8O1D4DLg@mail.gmail.com \
    --to=bnason@netflix.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).