git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Leila <muhtasib@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-status: Show empty directories
Date: Mon, 11 Jun 2012 14:51:23 -0400	[thread overview]
Message-ID: <CAA3EhHLDwiCixY2xPRQOsvSv+AAKWUEWo1QgnpZrgDeeMe8wTg@mail.gmail.com> (raw)
In-Reply-To: <7vehpl7pn0.fsf@alter.siamese.dyndns.org>

On Mon, Jun 11, 2012 at 12:57 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Leila <muhtasib@gmail.com> writes:
>
>>> Having said all that, I personally doubt this is a useful change.  I
>>> may have thought of adding a README file to a relatively new project that
>>> does not yet have one while in shower but I haven't even created the
>>> file in the working tree.  And I forget about it once I get to the
>>> office.  Should the system remind me to create README and then add?
>>> Your patch would not give me such a reminder once the top-level
>>> directory is populated (because it is no longer empty).  Even if I
>>> were planning to add Documentation/README instead, I would get such
>>> a reminder only if the Documentation directory is empty. Once the
>>> directory is populated, I wouldn't get "create README and then add".
>>> Why should an empty directory so special?
> Please read what you quoted again.  I may have forgotten to create
> and add README
>
>  - at the toplevel directory; or
>
>  - in the Documentation directory that already has other tracked
>   files; or
>
>  - in the Documentation directory that does not have any file yet.
>
> Why do I get a reminder for only the last case?  Also please realize
> that at no point in the scenario I am interested in adding an empty
> directory.  "How does one add empty directories" is irrelevant to my
> question.
>
> A more reasonable answer would have been "the reminder is not about
> a yet-to-be-created README file, but is about an empty directory you
> might have wanted to place something---there is no way for Git to
> guess that you wanted the new file to be README, but at least having
> a totally empty directory laying around may be an indication that
> you wanted to do something intereseting in it but haven't yet".  If
> the proposed commit log message justified the behaviour to treat
> only the third one specially that way, I suspect it may make some
> sense.

I apologize, I misread the scenario and thought you were asking a
different question.

The patch/new implementation I put forth reminds you that you have an
empty dir. The reminder that you have an empty dir  isn't about a
yet-to-be-created README file, but about an empty directory that you
may have wanted to do something interesting in but haven't yet (like
create a README/some other file or delete it even). It servers as
helpful reminder to do something with that empty dir. Is that better?

  reply	other threads:[~2012-06-11 18:51 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-09 19:40 [PATCH] git-status: Show empty directories Leila Muhtasib
2012-06-09 20:13 ` konglu
2012-06-09 21:08   ` Leila
2012-06-09 21:14     ` Thomas Rast
2012-06-09 21:24       ` Leila
2012-06-09 21:47       ` konglu
2012-06-10  9:01         ` Thomas Rast
2012-06-10  9:46           ` konglu
2012-06-10 14:20             ` Leila
2012-06-11 15:08           ` Junio C Hamano
2012-06-10  7:15 ` Junio C Hamano
2012-06-10 16:02   ` Leila
2012-06-10 18:12     ` konglu
2012-06-10 18:17       ` Leila
2012-06-11 16:57     ` Junio C Hamano
2012-06-11 18:51       ` Leila [this message]
2012-06-11 19:00         ` Leila

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAA3EhHLDwiCixY2xPRQOsvSv+AAKWUEWo1QgnpZrgDeeMe8wTg@mail.gmail.com \
    --to=muhtasib@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).