git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Øyvind A. Holm" <sunny@sunbase.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: David Turner <dturner@twopensource.com>,
	"git@vger.kernel.org" <git@vger.kernel.org>,
	David Turner <dturner@twitter.com>
Subject: Re: [PATCH] refs.c: handle REFNAME_REFSPEC_PATTERN at end of page
Date: Wed, 9 Jul 2014 13:48:35 +0200	[thread overview]
Message-ID: <CAA787rn-jD_QpeDOxLU2D+_nV0GjFpXr9NaNpZ2L++1sn_gOag@mail.gmail.com> (raw)
In-Reply-To: <xmqq7g3pdoy7.fsf@gitster.dls.corp.google.com>

On 7 July 2014 20:05, Junio C Hamano <gitster@pobox.com> wrote:
> David Turner <dturner@twopensource.com> writes:
> > When a ref crosses a memory page boundary, we restart the parsing at
> > the beginning with the bytewise code.  Pass the original flags to
> > that code, rather than the current flags.
>
> Good.

I've run the whole test suite with this patch applied, and it fixes the
problem on 64-bit Debian 7.5.

> I probably should add:
>     Reported-by: Øyvind A. Holm <sunny@sunbase.org>
>
> before your sign-off.

Thanks. :)

Cheers,
Øyvind

  parent reply	other threads:[~2014-07-09 11:48 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-03 21:55 t5150-request-pull.sh fails on newest master in Debian Øyvind A. Holm
2014-07-03 22:16 ` David Turner
     [not found]   ` <CAA787rmroFsjk9=ar0e_4o3hUpfDBi+9J4nrNyHHMZq-5q4skw@mail.gmail.com>
2014-07-03 23:02     ` Øyvind A. Holm
2014-07-03 22:19 ` Øyvind A. Holm
2014-07-04 20:22 ` David Turner
2014-07-05  0:09   ` Øyvind A. Holm
2014-07-05  1:58     ` David Turner
2014-07-05 14:24       ` Øyvind A. Holm
2014-07-05 19:00         ` [PATCH] refs.c: handle REFNAME_REFSPEC_PATTERN at end of page David Turner
     [not found]           ` <xmqq7g3pdoy7.fsf@gitster.dls.corp.google.com>
2014-07-09 11:48             ` Øyvind A. Holm [this message]
2014-07-09  0:52         ` t5150-request-pull.sh fails on newest master in Debian Øyvind A. Holm
2014-07-09  1:18           ` David Turner
2014-07-09 11:44             ` Øyvind A. Holm
2014-07-09 14:52             ` René Scharfe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAA787rn-jD_QpeDOxLU2D+_nV0GjFpXr9NaNpZ2L++1sn_gOag@mail.gmail.com \
    --to=sunny@sunbase.org \
    --cc=dturner@twitter.com \
    --cc=dturner@twopensource.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).