From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pat Thoyts Subject: Re: [PATCH] gitk: fix the display of files when filtered by path Date: Thu, 15 Dec 2011 21:18:19 +0000 Message-ID: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=bcaec50162d50c967404b4280614 Cc: msysGit , Pat Thoyts , Johannes Schindelin , Git , David Aguilar , Junio C Hamano , Paul Mackerras To: Martin von Zweigbergk X-From: msysgit+bncCOL1rfnnEBCdyKn3BBoEoFpJMw@googlegroups.com Thu Dec 15 22:18:56 2011 Return-path: Envelope-to: gcvm-msysgit@m.gmane.org Received: from mail-vx0-f186.google.com ([209.85.220.186]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RbIhX-0002BH-QU for gcvm-msysgit@m.gmane.org; Thu, 15 Dec 2011 22:18:51 +0100 Received: by mail-vx0-f186.google.com with SMTP id gb30sf968194vcb.3 for ; Thu, 15 Dec 2011 13:18:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=beta; h=x-beenthere:received-spf:mime-version:date:message-id:subject:from :to:cc:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:x-google-group-id:list-post :list-help:list-archive:sender:list-subscribe:list-unsubscribe :content-type; bh=W2uApndx3JAd0likRcoFnZYRRNlvkDXEEh7GiMKyDJY=; b=KCoQGPtMffpV0Toj0bKDAnePpqOaUlbAEuobouQVEPbezh20Tm5rFB51NSJAP7E2MH a59VJEZUIJlh4yXdBGKWvU5Bv47SSuxJntlzlTuFlAJDrgO81OHIN5o7hurEtNrARtZt qgVKPFLt36EbLcSbtONzAUpxxo17hvTNjteRI= Received: by 10.52.76.169 with SMTP id l9mr774065vdw.17.1323983901233; Thu, 15 Dec 2011 13:18:21 -0800 (PST) X-BeenThere: msysgit@googlegroups.com Received: by 10.52.178.105 with SMTP id cx9ls1677744vdc.0.gmail; Thu, 15 Dec 2011 13:18:20 -0800 (PST) Received: by 10.52.24.134 with SMTP id u6mr3662855vdf.8.1323983900202; Thu, 15 Dec 2011 13:18:20 -0800 (PST) Received: by 10.52.24.134 with SMTP id u6mr3662853vdf.8.1323983900182; Thu, 15 Dec 2011 13:18:20 -0800 (PST) Received: from mail-vw0-f41.google.com (mail-vw0-f41.google.com [209.85.212.41]) by gmr-mx.google.com with ESMTPS id ij1si2181001vdb.3.2011.12.15.13.18.20 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 15 Dec 2011 13:18:20 -0800 (PST) Received-SPF: pass (google.com: domain of patthoyts@gmail.com designates 209.85.212.41 as permitted sender) client-ip=209.85.212.41; Received: by vbbfn1 with SMTP id fn1so2025643vbb.28 for ; Thu, 15 Dec 2011 13:18:20 -0800 (PST) Received: by 10.52.93.146 with SMTP id cu18mr4574774vdb.56.1323983900022; Thu, 15 Dec 2011 13:18:20 -0800 (PST) Received: by 10.52.181.200 with HTTP; Thu, 15 Dec 2011 13:18:19 -0800 (PST) Received: by 10.52.181.200 with HTTP; Thu, 15 Dec 2011 13:18:19 -0800 (PST) X-Original-Sender: patthoyts@gmail.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of patthoyts@gmail.com designates 209.85.212.41 as permitted sender) smtp.mail=patthoyts@gmail.com; dkim=pass (test mode) header.i=@gmail.com Precedence: list Mailing-list: list msysgit@googlegroups.com; contact msysgit+owners@googlegroups.com List-ID: X-Google-Group-Id: 152234828034 List-Post: , List-Help: , List-Archive: Sender: msysgit@googlegroups.com List-Subscribe: , List-Unsubscribe: , Archived-At: --bcaec50162d50c967404b4280614 Content-Type: text/plain; charset=UTF-8 On Dec 15, 2011 8:01 PM, "Martin von Zweigbergk" < martin.von.zweigbergk@gmail.com> wrote: > > Hi, > > On Thu, Dec 15, 2011 at 1:24 AM, Johannes Schindelin > wrote: > > Hi, > > > > On Wed, 14 Dec 2011, David Aguilar wrote: > > > >> On Tue, Dec 13, 2011 at 8:50 AM, Pat Thoyts > >> wrote: > >> > Launching 'gitk -- .' or 'gitk -- ..\t' restricts the display to files > >> > under the given directory but the file list is left empty. This is because > >> > the path_filter function fails to match the filenames which are relative > >> > to the working tree to the filter which is filessytem relative. > >> > This solves the problem by making both names fully qualified filesystem > >> > paths before performing the comparison. > > How is this related to my patches from April? See > http://thread.gmane.org/gmane.comp.version-control.git/170853. It's > clearly not the same problem, but will the patches conflict? Will some > of mine be unnecessary? > > > Thanks for reminding me that I did not yet apply and push. Did so now. > > What do you mean by this? Push to where? > git://git.kernel.org/pub/scm/gitk/gitk.git is still down. This is about msysgit as I also posted this there. > Paul and Junio, the patches I sent in April are still not in git.git, > are they? Can we use another repo until the kernel.org one is up? More > than eight months to get a patch (or eight) merged is way too long, > IMO. > > Martin I'm not sure how this might relate to your patches. I've got a version merged on top of the last version of the gitk report that I have which includes those and it seems fine. As stated I did this work against git-core as the gitk repository continues to be unavailable. However as I have a pretty current snapshot I have pushed this to github to provide some visibility of things I know are not present within git-core. See http://github.com/patthoyts/gitk.git On Dec 15, 2011 8:01 PM, "Martin von Zweigbergk" < martin.von.zweigbergk@gmail.com> wrote: --bcaec50162d50c967404b4280614 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On Dec 15, 2011 8:01 PM, "Martin von Zweigbergk" <martin.von.zweigbergk@gmail.com&= gt; wrote:
>
> Hi,
>
> On Thu, Dec 15, 2011 at 1:24 AM, Johannes Schindelin
> <Johannes.Schindelin@= gmx.de> wrote:
> > Hi,
> >
> > On Wed, 14 Dec 2011, David Aguilar wrote:
> >
> >> On Tue, Dec 13, 2011 at 8:50 AM, Pat Thoyts
> >> <pattho= yts@users.sourceforge.net> wrote:
> >> > Launching 'gitk -- .' or 'gitk -- ..\t' = restricts the display to files
> >> > under the given directory but the file list is left empt= y. This is because
> >> > the path_filter function fails to match the filenames wh= ich are relative
> >> > to the working tree to the filter which is filessytem re= lative.
> >> > This solves the problem by making both names fully quali= fied filesystem
> >> > paths before performing the comparison.
>
> How is this related to my patches from April? See
> http://thread.gmane.org/gmane.comp.version-control.git/170853. It&#= 39;s
> clearly not the same problem, but will the patches conflict? Will some=
> of mine be unnecessary?
>
> > Thanks for reminding me that I did not yet apply and push. Did so= now.
>
> What do you mean by this? Push to where?
> git://git.kern= el.org/pub/scm/gitk/gitk.git is still down.

This is about msysgit as I also posted this there.

> Paul and Junio, the patches I sent in April are still not in git.gi= t,
> are they? Can we use another repo until the kernel.org one is up? More
> than eight months to get a patch (or eight) merged is way too long, > IMO.
>
> Martin

I'm not sure how this might relate to your patches. I've got a v= ersion merged on top of the last version of the gitk report that I have whi= ch includes those and it seems fine. As stated I did this work against git-= core as the gitk repository continues to be unavailable. However as I have = a pretty current snapshot=C2=A0 I have pushed this to github to provide som= e visibility of things I know are not present within git-core. See http://github.com/patthoyts/gitk.= git

On Dec 15, 2011 8:01 PM, "Martin von Zweigb= ergk" <martin.vo= n.zweigbergk@gmail.com> wrote:
--bcaec50162d50c967404b4280614--