From: Erik Faye-Lund <kusmabite@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org, msysgit@googlegroups.com, peff@peff.net
Subject: Re: [PATCH/RFC] compat/terminal: support echoing on windows
Date: Sun, 24 Jun 2012 17:38:24 +0200 [thread overview]
Message-ID: <CABPQNSYLL_eHzo6LjNJWdO-WOfxbCUz2GPyg8p5Vvc0FmToPEg@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.1.00.1206240938050.16012@bonsai2>
On Sun, Jun 24, 2012 at 4:38 PM, Johannes Schindelin
<Johannes.Schindelin@gmx.de> wrote:
> Hi,
>
> On Sun, 24 Jun 2012, Erik Faye-Lund wrote:
>
>> Without /dev/tty support, git_terminal_prompt simply ignores the
>> 'echo'-parameter. On Windows we can do better by clevering up our
>> getpass-implementation a bit so it can conditionally echo.
>>
>> While we're at it, plug a small memory-leak by returning a pointer
>> to a static strbuf instead of detaching it. This is the same thing
>> the /dev/tty-version of git_terminal_prompt does, and the callee
>> doesn't expect to have to free it's memory.
>
> Looks good, please apply!
Done.
--
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.
You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en
next prev parent reply other threads:[~2012-06-24 15:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-24 13:35 [PATCH/RFC] compat/terminal: support echoing on windows Erik Faye-Lund
2012-06-24 14:38 ` Johannes Schindelin
2012-06-24 15:38 ` Erik Faye-Lund [this message]
2012-06-25 15:06 ` Erik Faye-Lund
2012-06-27 21:08 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABPQNSYLL_eHzo6LjNJWdO-WOfxbCUz2GPyg8p5Vvc0FmToPEg@mail.gmail.com \
--to=kusmabite@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=msysgit@googlegroups.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).