git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Erik Faye-Lund <kusmabite@gmail.com>
To: Vincent van Ravesteijn <vfr@lyx.org>
Cc: Philip Oakley <philipoakley@iee.org>,
	Andrew Ardill <andrew.ardill@gmail.com>,
	Git MsysGit <msysgit@googlegroups.com>,
	git@vger.kernel.org
Subject: Re: Compiling on Windows
Date: Fri, 21 Oct 2011 13:41:25 +0200	[thread overview]
Message-ID: <CABPQNSYkBg9pc15kCgzcoqhHFVom48zxYmT4N1GbyRsdLvC9iA@mail.gmail.com> (raw)
In-Reply-To: <4EA094D2.7050807@lyx.org>

On Thu, Oct 20, 2011 at 11:38 PM, Vincent van Ravesteijn <vfr@lyx.org> wrote:
>
>>> I once wrote a little step-by-step tutorial on how to compile the native
>>> Windows Git with MSVC (Express).
>>>
>>> http://blog.vfrconsultancy.nl/#post0
>>
>> The blog post filled in a few gaps in the Msysgit README instructions
>> about where to place the various downloads described.
>
> I updated the post a little so that it actually works again. I somehow like
> to have a real native Windows compilation of Git.

Git for Windows is a "real native Windows compilation of Git". You
don't need a MSVC-compiled binary for that.

> To successfully compile Git, we also need to change
>>
>> #include <sys/resource.h>
>
> into
>>
>> #include <io.h>
>
> I have seen some communication about this in the past, but nobody cared
> enough to fix this.
>

There's been some patches dealing with this recently on the msysgit
mailing list. Look for the patches prefixed with "MSVC" in Karsten
Blees' Unicode series. They will be kicked out of the next iteration
of the Unicode series, but if you want to pick them up, clean up the
issues pointed out and re-submit them, that'd be very welcome.

> Shall I sent a patch that adds a file "compat/win32/sys/resource.h" which
> just includes "io.h" ? Or is there another more prefered way to fix this ?

I would prefer <io.h> to be included from compat/msvc.h instead,
because <io.h> isn't a <sys/resource.h> replacement.

As for the missing <sys/resource.h>, I'm not so sure. We don't have
<sys/resource.h> in msysGit either, and I personally don't like the
whole adding-stub-headers approach too much, but it does seem to be
the precedence set for the MSVC-build...

In general I'd say that no-one have worked the MSVC-support in a
while, patches would be welcome :)

      reply	other threads:[~2011-10-21 11:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-18  4:08 Compiling on Windows Andrew Ardill
2011-10-18  5:41 ` Frans Klaver
2011-10-18  6:17   ` Andrew Ardill
2011-10-18 14:02     ` Erik Faye-Lund
2011-10-18 16:07       ` Sebastian Schuberth
2011-10-18  6:39 ` Alexey Shumkin
2011-10-19  7:49 ` Vincent van Ravesteijn
2011-10-19 21:46   ` Philip Oakley
2011-10-19 23:17     ` [msysGit] " Johannes Schindelin
2011-10-20  7:06       ` Philip Oakley
2011-10-20 21:38     ` Vincent van Ravesteijn
2011-10-21 11:41       ` Erik Faye-Lund [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABPQNSYkBg9pc15kCgzcoqhHFVom48zxYmT4N1GbyRsdLvC9iA@mail.gmail.com \
    --to=kusmabite@gmail.com \
    --cc=andrew.ardill@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=msysgit@googlegroups.com \
    --cc=philipoakley@iee.org \
    --cc=vfr@lyx.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).