From: Erik Faye-Lund <kusmabite@gmail.com>
To: Elia Pinto <gitter.spiros@gmail.com>
Cc: GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH 4/6] contrib/credential/osxkeychain/git-credential-osxkeychain.c: reduce scope of variables
Date: Wed, 16 Apr 2014 11:55:03 +0200 [thread overview]
Message-ID: <CABPQNSa2dqzkKcaMycHQ9SUNL9tLvJGXPF4wPxv23NmFEnvrTQ@mail.gmail.com> (raw)
In-Reply-To: <1397640811-17719-4-git-send-email-gitter.spiros@gmail.com>
On Wed, Apr 16, 2014 at 11:33 AM, Elia Pinto <gitter.spiros@gmail.com> wrote:
> Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
> ---
> contrib/credential/osxkeychain/git-credential-osxkeychain.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/contrib/credential/osxkeychain/git-credential-osxkeychain.c b/contrib/credential/osxkeychain/git-credential-osxkeychain.c
> index bcd3f57..5ae09f6 100644
> --- a/contrib/credential/osxkeychain/git-credential-osxkeychain.c
> +++ b/contrib/credential/osxkeychain/git-credential-osxkeychain.c
> @@ -163,12 +163,12 @@ static void read_credential(void)
>
> int main(int argc, const char **argv)
> {
> - const char *usage =
> - "usage: git credential-osxkeychain <get|store|erase>";
> -
> if (!argv[1])
> + {
> + const char *usage =
> + "usage: git credential-osxkeychain <get|store|erase>";
> die(usage);
> -
> + }
Again, not our code-style.
next prev parent reply other threads:[~2014-04-16 9:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 9:33 [PATCH 1/6] compat/regex/regcomp.c: reduce scope of variables Elia Pinto
2014-04-16 9:33 ` [PATCH 2/6] compat/regex/regex_internal.c: " Elia Pinto
2014-04-16 9:33 ` [PATCH 3/6] compat/regex/regexec.c: " Elia Pinto
2014-04-16 9:33 ` [PATCH 4/6] contrib/credential/osxkeychain/git-credential-osxkeychain.c: " Elia Pinto
2014-04-16 9:55 ` Erik Faye-Lund [this message]
2014-04-16 9:33 ` [PATCH 5/6] contrib/credential/wincred/git-credential-wincred.c: " Elia Pinto
2014-04-16 9:54 ` Erik Faye-Lund
2014-04-16 9:33 ` [PATCH 6/6] xdiff/xprepare.c: " Elia Pinto
2014-04-16 9:55 ` Erik Faye-Lund
2014-04-16 16:49 ` [PATCH 1/6] compat/regex/regcomp.c: " Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABPQNSa2dqzkKcaMycHQ9SUNL9tLvJGXPF4wPxv23NmFEnvrTQ@mail.gmail.com \
--to=kusmabite@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitter.spiros@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).